From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30390 invoked by alias); 8 Dec 2017 10:13:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30373 invoked by uid 89); 8 Dec 2017 10:13:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 10:13:31 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8ACCF6868A; Fri, 8 Dec 2017 10:13:30 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3175919CB3; Fri, 8 Dec 2017 10:13:30 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id vB8ADQmq031641; Fri, 8 Dec 2017 11:13:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id vB8ADPq9031640; Fri, 8 Dec 2017 11:13:25 +0100 Date: Fri, 08 Dec 2017 10:13:00 -0000 From: Jakub Jelinek To: Rainer Orth Cc: Martin Sebor , Jason Merrill , Gcc Patch List Subject: Re: [PATCH 5/3] C++ bits to improve detection of attribute conflicts (PR 81544) Message-ID: <20171208101324.GQ2353@tucnak> Reply-To: Jakub Jelinek References: <4899e27e-6fc3-a887-7888-9f7810a07aaa@gmail.com> <31b7c6fd-3409-5029-5dea-d91310536cbb@redhat.com> <4b022406-f61e-5e1b-7df8-65b455e43094@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00457.txt.bz2 On Fri, Dec 08, 2017 at 10:43:58AM +0100, Rainer Orth wrote: > The line numbers are completely misleading, unfortunately. Hadn't > SUBTARGET_ATTRIBUTE_TABLE been used at the end of the (very short) > sparc_attribute_table, I wouldn't have seen what was wrong. > > The following patch fixes the problem, installed on mainline after > i386-pc-solaris2.11 and sparc-sun-solaris2.11 bootstraps completed > without regressions. > > However, there are two more SUBTARGET_ATTRIBUTE_TABLE defines: > > gcc/config/darwin.h:#define SUBTARGET_ATTRIBUTE_TABLE \ > gcc/config/i386/cygming.h:#define SUBTARGET_ATTRIBUTE_TABLE \ I'll deal with this. > 2017-12-08 Rainer Orth > > * config/sol2.h (SOLARIS_ATTRIBUTE_TABLE): Initialize new member > of struct attribute_spec. Ok for trunk. Jakub