From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38387 invoked by alias); 11 Dec 2017 20:58:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35682 invoked by uid 89); 11 Dec 2017 20:57:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=kc3 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Dec 2017 20:57:57 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBBKuq0u073467 for ; Mon, 11 Dec 2017 15:57:55 -0500 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 2esy28eqcs-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 11 Dec 2017 15:57:55 -0500 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 11 Dec 2017 13:57:54 -0700 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 11 Dec 2017 13:57:52 -0700 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vBBKvqIP4522426; Mon, 11 Dec 2017 13:57:52 -0700 Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B8316A03B; Mon, 11 Dec 2017 13:57:52 -0700 (MST) Received: from ibm-tiger.the-meissners.org (unknown [9.32.77.111]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP id 2B8356A043; Mon, 11 Dec 2017 13:57:52 -0700 (MST) Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id 734AF492F5; Mon, 11 Dec 2017 15:57:51 -0500 (EST) Date: Mon, 11 Dec 2017 20:58:00 -0000 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c Mail-Followup-To: Michael Meissner , Segher Boessenkool , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt References: <20171127192131.GA15914@ibm-tiger.the-meissners.org> <20171127234009.GA28990@ibm-tiger.the-meissners.org> <20171130024250.GX10515@gate.crashing.org> <20171130205425.GA11524@ibm-tiger.the-meissners.org> <20171201054022.GA5348@ibm-tiger.the-meissners.org> <20171201235355.GL10515@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201235355.GL10515@gate.crashing.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17121120-0008-0000-0000-000009040CE0 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008190; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00958811; UDB=6.00484849; IPR=6.00738833; BA=6.00005736; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018487; XFM=3.00000015; UTC=2017-12-11 20:57:54 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121120-0009-0000-0000-0000451E289A Message-Id: <20171211205750.GA16210@ibm-tiger.the-meissners.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-11_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712110298 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00647.txt.bz2 On Fri, Dec 01, 2017 at 05:53:55PM -0600, Segher Boessenkool wrote: > On Fri, Dec 01, 2017 at 12:40:22AM -0500, Michael Meissner wrote: > > After committing the previous patch, I noticed that it was now generating > > warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't > > noticed during development of the patch. This is due to the fact that before I > > added the ifunc support, it was only compiling __{mul,div}kc3, and those have > > built-in declarations. I installed this patch as being obvious: > > > > 2017-11-30 Michael Meissner > > > > * config/rs6000/_mulkc3.c (__mulkc3): Add forward declaration. > > * config/rs6000/_divkc3.c (__divkc3): Likewise. > > > > Index: libgcc/config/rs6000/_divkc3.c > > =================================================================== > > --- libgcc/config/rs6000/_divkc3.c (revision 255288) > > +++ libgcc/config/rs6000/_divkc3.c (working copy) > > @@ -37,6 +37,8 @@ typedef __complex float KCtype __attribu > > #define __divkc3 __divkc3_sw > > #endif > > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); > > + > > KCtype > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) > > { > > How does this warn? -Wmissing-declarations? Should this declaration be > in a header then? The compiler creates the call to __mulkc3 and __divkc3, and internally it has the appropriate prototype like it does for all built-in functions (in this case, returning an _Float128 _Complex type, and taking 4 _Float128 arguments). So before adding ifunc support, we never noticed it didn't have a prototype, because the compiler already has a prototype. With ifunc support, we now need to create two separate functions, __mulkc3_sw and __mulkc3_hw, and make __multkc3 the ifunc resolver. So there really isn't an include file that is appropriate to put the definitions in. I could change it to use the soft-fp includes (including quadmath-float128.h) if desired. Did you want me to do that? > A code comment explaining why you do a declaration for exactly the same > thing as there is two lines later would help; otherwise people will try > to delete it again :-) -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797