From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
Martin Sebor <msebor@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c
Date: Wed, 13 Dec 2017 20:57:00 -0000 [thread overview]
Message-ID: <20171213205719.GB10515@gate.crashing.org> (raw)
In-Reply-To: <20171212215635.GA18332@ibm-tiger.the-meissners.org>
On Tue, Dec 12, 2017 at 04:56:36PM -0500, Michael Meissner wrote:
> On Tue, Dec 12, 2017 at 11:04:55AM -0600, Segher Boessenkool wrote:
> > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote:
> > > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype);
> > > > > +
> > > > > KCtype
> > > > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d)
> > > > > {
> > > >
> > > > How does this warn? -Wmissing-declarations? Should this declaration be
> > > > in a header then?
> As Andreas points out, the option -Wmissing-prototypes complains if a global
> function is compliled without prototypes for C/Objective C.
>
> Before the patch, the internal definition within the compiler meant that that
> __mulkc3 would not get the warning. Now with separate ifunc handlers, both
> __mulkc3_sw and __mulkc3_hw got warnings.
Gotcha. There isn't a nice header file for it, so sure that is fine
the way you have it. Thanks for the explanation!
Segher
prev parent reply other threads:[~2017-12-13 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 19:57 Michael Meissner
2017-11-27 22:55 ` Martin Sebor
2017-11-28 0:55 ` Michael Meissner
2017-11-30 5:08 ` Segher Boessenkool
2017-11-30 21:52 ` Michael Meissner
2017-12-01 5:40 ` Michael Meissner
2017-12-01 23:54 ` Segher Boessenkool
2017-12-11 20:58 ` Michael Meissner
2017-12-12 17:05 ` Segher Boessenkool
2017-12-12 17:18 ` Andreas Schwab
2017-12-12 21:56 ` Michael Meissner
2017-12-13 20:57 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213205719.GB10515@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=msebor@gmail.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).