From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114382 invoked by alias); 13 Dec 2017 20:57:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114355 invoked by uid 89); 13 Dec 2017 20:57:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 20:57:30 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vBDKvMt8008513; Wed, 13 Dec 2017 14:57:27 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id vBDKvLuV008506; Wed, 13 Dec 2017 14:57:21 -0600 Date: Wed, 13 Dec 2017 20:57:00 -0000 From: Segher Boessenkool To: Michael Meissner , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c Message-ID: <20171213205719.GB10515@gate.crashing.org> References: <20171127192131.GA15914@ibm-tiger.the-meissners.org> <20171127234009.GA28990@ibm-tiger.the-meissners.org> <20171130024250.GX10515@gate.crashing.org> <20171130205425.GA11524@ibm-tiger.the-meissners.org> <20171201054022.GA5348@ibm-tiger.the-meissners.org> <20171201235355.GL10515@gate.crashing.org> <20171211205750.GA16210@ibm-tiger.the-meissners.org> <20171212170455.GT10515@gate.crashing.org> <20171212215635.GA18332@ibm-tiger.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171212215635.GA18332@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00853.txt.bz2 On Tue, Dec 12, 2017 at 04:56:36PM -0500, Michael Meissner wrote: > On Tue, Dec 12, 2017 at 11:04:55AM -0600, Segher Boessenkool wrote: > > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote: > > > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); > > > > > + > > > > > KCtype > > > > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) > > > > > { > > > > > > > > How does this warn? -Wmissing-declarations? Should this declaration be > > > > in a header then? > As Andreas points out, the option -Wmissing-prototypes complains if a global > function is compliled without prototypes for C/Objective C. > > Before the patch, the internal definition within the compiler meant that that > __mulkc3 would not get the warning. Now with separate ifunc handlers, both > __mulkc3_sw and __mulkc3_hw got warnings. Gotcha. There isn't a nice header file for it, so sure that is fine the way you have it. Thanks for the explanation! Segher