From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13221 invoked by alias); 21 Dec 2017 20:55:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13121 invoked by uid 89); 21 Dec 2017 20:55:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*ubuntu.com X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr60070.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (40.107.6.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 20:55:24 +0000 Received: from VI1PR0802CA0011.eurprd08.prod.outlook.com (2603:10a6:800:aa::21) by HE1PR0801MB1529.eurprd08.prod.outlook.com (2603:10a6:3:13::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.345.14; Thu, 21 Dec 2017 20:55:19 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::208) by VI1PR0802CA0011.outlook.office365.com (2603:10a6:800:aa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.345.14 via Frontend Transport; Thu, 21 Dec 2017 20:55:19 +0000 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; ubuntu.com; dkim=none (message not signed) header.d=none;ubuntu.com; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 217.140.96.140 as permitted sender) receiver=protection.outlook.com; client-ip=217.140.96.140; helo=nebula.arm.com; Received: from nebula.arm.com (217.140.96.140) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.302.6 via Frontend Transport; Thu, 21 Dec 2017 20:55:18 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.294.0; Thu, 21 Dec 2017 20:55:12 +0000 Date: Thu, 21 Dec 2017 20:55:00 -0000 From: James Greenhalgh To: Steve Ellcey CC: gcc-patches , Richard Earnshaw , Marcus Shawcroft , , , Subject: Re: [Patch][Aarch64] Fix multi-arch support in ILP32 mode Message-ID: <20171221205511.GA38061@arm.com> References: <1513882582.5026.74.camel@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1513882582.5026.74.camel@cavium.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(39860400002)(376002)(396003)(39380400002)(2980300002)(438002)(199004)(24454002)(189003)(246002)(1076002)(26826003)(50466002)(36756003)(76176011)(72206003)(23726003)(356003)(305945005)(7696005)(478600001)(33656002)(86362001)(106466001)(2906002)(229853002)(83506002)(77096006)(55016002)(4326008)(6246003)(54906003)(106002)(8936002)(47776003)(46406003)(8676002)(2950100002)(6916009)(104016004)(316002)(58126008)(6286002)(16586007)(5660300001)(97756001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1529;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VE1EUR03FT027;1:o/g4Rk1g0TZUdH1SzOyt5OdY0nN1gCiLFAlv44EGq9AZ2NRPeT+8v0g/0LX4Qrs9+ou9MtQvm0Ez56kZEhKDhRSWULi0qZbsRPQnhcOgjMD56fxpSer6/3l0imo6UOad X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9e9fed6-ef9b-48a3-5fe9-08d548b524f5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008031)(4608076)(2017052603307)(7153060);SRVR:HE1PR0801MB1529; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1529;3:CExARh5NCVnsGNgq2oWwV7VMlciF+oDn4pbEAbdpKFA0lUxhQ3JKiCk7MSZfrL+Ig47jZ3rwf4NxOqRTEA6GxJpO0KIlZqQ62SmN1OyMtiFY/yHOkosZ5QHloOv95lBOMJBnVm+oS0STkYjaig1nZY45Dm/tgfKkstESePbdz1g7imzj4XIlvz3RmBFXQuo2W7mMZr4YL9ID+lYBwwLvJKPQlR//Cye4yf6I8kdJoGtSBKLRBlYRt2CeA4m2Y3h6odjkycRsgqosw7CUQRNDOFmwuHnw3SazYCmktHXUPgoV20Km45Ih1RDn58Wg/Ua4G9cdAQxKAbIHTe8SVznoDuaaU/iRfL5nCKqV9JRe4SY=;25:BhtsIt8tCWYzKZoKhu9WJq0/57rs/mU2RXF+phplM2S0zAvOYP0j2zM91UAcUh4K2lbBR5eCHP0zf6wtiPUiX63RAtTANUzHuRCMr0oidCbSzQcevnAf8ryan4yOqR9Rd/MWhDQRec83HXLe4G403XB7DHCIO09UWkCxLZzKRJMGaTMIS029AIEZmiu534vj/TlfeEby/GJpBSv5VL4bEfL/8Zcxec8H7+dkT37qNeuL/yDNoMwuMBjnn99AS8/GkGhVWz4vPoW+pHheWhAkV74sch0cvWhGcyYGePrNSUqHlPQFw6j33ptDFUS7jFsji0qxp7Gcgwvz36qpgVwstQ== X-MS-TrafficTypeDiagnostic: HE1PR0801MB1529: X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1529;31:7mQWmbIG3IkD3ZTtl8WdtB3v/E/i9fL2hUKVtz7fCybfbThuTWUVxEQzLDOCwsmSUpRgwwlDRd6FyhIl0HyILw2LL65O/bqk4ec1/Hk6IuRb2EFT7dkY0uZgbROIMUiFbX2feiQHBWeeVxZyfkRGLNb3oqiiLs/Zq7EtZf0RrZGrxYI5RMcIJ3Fw0e55+QqfNAK9MMvqYDuB8uYer8ebGFyV0UZFzJIg23EGmkqw+so=;20:ZfJxMSEoYY75EO8KbKCHXESRW0BbVQRVYYApv0gnPRg/CMb0UzAyZY8mTbf7scTP5IVuYfhcxEq8TGXJHFcWnFRCMwb0GMlcrrwjl1BUgZH5kmwPz/+8RMvX2V+wT9y+awLZfxt9QHvqSLHLmZ2oYH/6POEG81f9vDqus6g6vesQaFSDOaygXGIlBIdrQhRwrxjo9kOWsOYsTmeyms6iwJPy5RhQtlmrw657//1rPjWjbLpxZlsDUoyhkOUB0uM3;4:tNGP+gDPyVNu3qzFK2fGfGPnoqGJKbaZ6FSLusuOPZDE4wttkhcO4lHj78zvgjl3AMvvA9U7Pd6M+6WSuSgaG/vcXxd55u4RqNb2RDFDKhbsH508ARTeS6RUj9vbKmiEbDVKaK4ktZ6BbELGOO87phTK94uWLNpmbWZVwIgEWP01I2O6b65Jug8kVtPxt5nRTDLLCwofC17BGif2hBMcZrOMTXD4Rx4QgkaMBuYDvq1HbI7UY9OhI1URgFm8rflK5IKnkZ4sMW2dqet/LhCCstK2FzvuJ75Tg2W2JZ5Q+j/NJ6XlsJfpQPAms6qUCzKk NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93004095)(10201501046)(3231023)(6055026)(6041268)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:HE1PR0801MB1529;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:HE1PR0801MB1529; X-Forefront-PRVS: 0528942FD8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0801MB1529;23:lvYftZUm2WbnphCOdjU85GULBz2a5VntbYEGOH1?= =?us-ascii?Q?RbBUm7cMQybtsCrgGpQf6d0RQmkJopRWYx3dL5XnRygnPKdWiCTHkVXbMBU6?= =?us-ascii?Q?h9DJ4E/8VOjb0basuYHM9blkpFTDEC19UfCbonclPw+BgwEUXMGsMgPQ5r6o?= =?us-ascii?Q?IE4haxXyegvZtULwUc0iC3P7qMh6a1fscdtQ9Kz/6qCP9PvNQEnELbnv5WNt?= =?us-ascii?Q?QJz1ufBsp61vuycXQzebAtKbDkhS7j+4o6v6tooI6DSrCFXdbPLLXiR/sdmD?= =?us-ascii?Q?2v63u7ka0AMlLIkVBsW3Srb4BmhfRFnEzK7x4RTXl421z3hN8QWpYnys4knF?= =?us-ascii?Q?wwb/8JWCtr9s8aWzN0gHeRpqtuzQ7X/JJDpg27UwLPieeT5gG4IQzDCYoZMF?= =?us-ascii?Q?ATuUSN0r+NGGexIFL/UZqZKREjPVTQ8vDL5OHicoEZ9v+2LC5Yuyg5zfOc3F?= =?us-ascii?Q?1g4ibL7VqRjSMQs1m3jWROQAOyO0XcrbCfaHQlbKKmt4lPK+xByvKlpcaHUu?= =?us-ascii?Q?XxEN6Ej4DgEjw4ZLjlNQD7s16fWbXzEcq3E7mrG9PWjqEmNkGXUnL1f9HPRi?= =?us-ascii?Q?+qUcciDg0CllvzJMCDnFKFLgd8b9j+mdoYKd8pAu1c6LNdx5SaM19QyW7KGg?= =?us-ascii?Q?ELFRs1ySPG8CPqN3AZwWqE9yht0Q2G2nq3sgUjJHotR3qlBdSz0U9bRRTYiQ?= =?us-ascii?Q?9zmoXwZt2kBOUTMaa1imJJOoVb2jG43I4VBR8X9v3RmnJbBizyMHSYL/cp/H?= =?us-ascii?Q?ztSe5B8IoYO4dEFA15q3KLdBcYp+EcJ8WLyT1mz9QuaHxS6TqDRXS7Jm5Btj?= =?us-ascii?Q?hgo5wemM7uCJbtYet6w7HMSUeo3W9w4XnsCh4/YQBjYCrMN10sDxl4g2nucO?= =?us-ascii?Q?zxc2z32uz6h8zoZiSdusPCFwlP5MwFy3cLyofOfbChvQcRHQP0qze4+Zx2K5?= =?us-ascii?Q?/WtJ57I6AQxRvzdG5PoNppiwgE9RK0TGtQceT98LvP8bRD9XzFWP2HoV4PGS?= =?us-ascii?Q?nKTK1rO6Hz0xr0+voeWd5WJl0SoxfrtXHfmyDibFgPaD0sXp6yG4Rvrxhv2x?= =?us-ascii?Q?mPV5c587+BaZm+8UTqH8QLX7jTt1uuPq4okSOOCV2kh51QDCj46CvtErbD9d?= =?us-ascii?Q?Rlc8PPuZwDpU=3D?= X-Microsoft-Antispam-Message-Info: +jcpHEbVj3Ie41HsDJS2pvHGpgTWbAwtX5wYRzixjtDcAi78s9uPt1jL86AJlwo4947+ZYxyzj8aNXJyZxMQ9A== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1529;6:PUZ0Pz9wRdvn0fUsfPPRDXrWxlDBmUqiR186rZ7ZqM7qKqa5r8k9RgzcxdTNhOHyE9ezMd6sUPknPJPCFDjaVVZ91sLn3Xgr1tJ4H97HFTiBTLNExV0HyE3VzYshp4V/Creo9EnjA4HA0z7pH3aQhjCKrLap2Nc4YHUzoVEr3WfT5bas8OUJ85S3zTRGWYCuFswe2oP7tPGSgDgGOWFIjtG874ciUgv1WN+VYvxrOv/m7m8dUg51I0m/h0WuIWZBRC/L8qZfXl4kn1WumOcxnuzPME/yqcdX9W4Vjmeu4HyeyCE96D89qTpo7oe1XYfDM7BBCAt+HaxBccMCFDl8PWhVxkpyAWqMpQqaeN/Zwxw=;5:fTe4zulP+M46ftLvFlkqDM0RYKEvzpbfQI2JyyGm/6YimEC1DOx/NiANMWjcIIX1C5JONrpdLDofNwHzqKyrnAq81azLwz2VAwiCbbx/7NYeIQSw+PuK8cV/1kXUBYtSabTro9UBeQlYzYrCVl9lqRztq9SYh/T8aGYNGdzJriU=;24:Ko9mKfiWaVyEbBKB5lGMOHYNbnma3KjR/9MVXaD1PnycxxhyLFelV5q/jfrgsbP/kmaHKOTFKcPxPe2L+leO8fFzuT9tp3Gq1fPph6HHkbI=;7:24gnt/FRSFw/tJNmuNU/B9Ns1NGwu8ojUKLP7K7zb5/JvaZZnotxWDFOnkib0MSrLtXWfUOsFeDJAQ5+kz1vypvaXRJjXGoagM8zh0mezd+eX1LHqnBSZUsJaEsbBQmXj+Czfwx2SyvI8wvawsGrDiC/IVeY1Sz1emB2Iid+hxS8AxOmoI03p3WfT+SI94wFCyA0qj7Bo8MPkhv8WExUQfcMvygoL/MAoxPkZbQVTRjw9QpIRQ5CoTfrcakWS/iK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 20:55:18.6321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9e9fed6-ef9b-48a3-5fe9-08d548b524f5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1529 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg01453.txt.bz2 On Thu, Dec 21, 2017 at 06:56:22PM +0000, Steve Ellcey wrote: > This one line patch for multi-arch support on Aarch64 and ILP32 was > submitted over a year ago and pinged a number of time since then, > since no one has objected and since it is only one line I am going > to check it in as an obvious fix. I think this is not obvious, and worse incorrect. I contacted Andrew off-list back in September to ask about this patch, the problem is the triplet used here: > -MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32 > +MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32$(call if_multiarch,:aarch64$(AARCH_BE)_ilp32-linux-gnu) As far as I understand it from Linaro connect and conversations with Debian/Ubuntu port maintainers, the correct triplet should be: aarch64-none-linux-gnu_ilp32 If you're revisiting this patch, it is OK to go in, but please use the agreed triplet. Thanks, James