From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [PATCH] PR libstdc++/83450 avoid -Wreturn-type warning in test
Date: Sun, 24 Dec 2017 09:18:00 -0000 [thread overview]
Message-ID: <20171224091850.GA32613@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
If the libc's declaration of pthread_exit isn't decorated with a
noreturn attribute then the recent changes to enable -Wreturn-type by
default cause this test to warn. Fixed by adding a return statement.
PR libstdc++/83450
* testsuite/21_strings/basic_string/pthread18185.cc: Add return
statement.
Tested powerpc64le-linux, committed to trunk.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 769 bytes --]
commit 70df8cb9325b7bac794b1135369165d99b7c6828
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Sun Dec 24 08:37:07 2017 +0000
PR libstdc++/83450 avoid -Wreturn-type warning in test
PR libstdc++/83450
* testsuite/21_strings/basic_string/pthread18185.cc: Add return
statement.
diff --git a/libstdc++-v3/testsuite/21_strings/basic_string/pthread18185.cc b/libstdc++-v3/testsuite/21_strings/basic_string/pthread18185.cc
index fb3d43de528..b6649178a0a 100644
--- a/libstdc++-v3/testsuite/21_strings/basic_string/pthread18185.cc
+++ b/libstdc++-v3/testsuite/21_strings/basic_string/pthread18185.cc
@@ -38,6 +38,7 @@ foo (void*)
{
pthread_exit (0);
}
+ return 0; // See libstdc++/83450
}
// c++/18185
reply other threads:[~2017-12-24 9:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171224091850.GA32613@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).