From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88107 invoked by alias); 8 Jan 2018 13:53:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 88089 invoked by uid 89); 8 Jan 2018 13:53:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=fear, june, June, Gentle X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jan 2018 13:53:35 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30C1A883CD; Mon, 8 Jan 2018 13:53:34 +0000 (UTC) Received: from localhost (unknown [10.33.36.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id D485C5C66F; Mon, 8 Jan 2018 13:53:33 +0000 (UTC) Date: Mon, 08 Jan 2018 14:07:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: std::forward_list optim for always equal allocator Message-ID: <20180108135333.GN7682@redhat.com> References: <05f263b4-b74f-da68-b661-3e6dbe027abb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <05f263b4-b74f-da68-b661-3e6dbe027abb@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2018-01/txt/msg00482.txt.bz2 On 23/11/17 22:22 +0100, François Dumont wrote: >Gentle reminder for this patch. > >I looked when the constructor got unused and I think it is back in >June 2015 in git commit: > >commit debb6aabb771ed02cb7256a7719555e5fbd7d3f7 >Author: redi >Date:   Wed Jun 17 17:45:45 2015 +0000 > >        * include/bits/forward_list.h >        (_Fwd_list_base(const _Node_alloc_type&)): Change parameter to >        rvalue-reference. Hmm, I should have put that same change on the gcc-5-branch too. >If you fear abi breaking change I can restore it in a >!_GLIBCXX_INLINE_VERSION section. I think if there was a problem here my June 2015 change would already have caused it (when I changed the _Fwd_list_base constructor signatures). So let's assume it's OK to remove the constructor. >@@ -533,15 +560,13 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER > > /** > * @brief The %forward_list move constructor. >- * @param __list A %forward_list of identical element and allocator >- * types. >+ * @param A %forward_list of identical element and allocator types. This change is wrong, you can't just remove the parameter name, because now Doxygen will document a parameter called "A" (and complain that there is no such parameter). It would be better to leave the name __list there and just get the warning. Otherwise the patch is OK for trunk (please ensure to update the Copyright dates in the test files to 2018). Thanks.