From: Jakub Jelinek <jakub@redhat.com>
To: Jeff Law <law@redhat.com>
Cc: Martin Sebor <msebor@gmail.com>,
Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>,
Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Christophe Lyon <christophe.lyon@linaro.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PR81703 and Martin's fix for PR83501
Date: Fri, 12 Jan 2018 17:56:00 -0000 [thread overview]
Message-ID: <20180112175534.GF2063@tucnak> (raw)
In-Reply-To: <3a12541d-e56c-21c8-fa51-bdebc8578c66@redhat.com>
On Fri, Jan 12, 2018 at 10:38:39AM -0700, Jeff Law wrote:
> >>> Thanks for pointing it out. I see it there as well with
> >>> Prathamesh's test case, though not with the test case in
> >>> bug 83543. It is the same root cause in both. I agree
> >>> that enhancing the strlen pass to handle this case would
> >>> be preferable to just xfailing the test. I'm just not
> >>> sure it's possible before stage 3 closes. If not, I'll
> >>> work on it in GCC 9. Although the details are target-
> >>> specific, the limitation affects all targets and so
> >>> having a solution will benefit all all of them.
> >> Indeed, however for now I am not sure what would be the best approach ?
> >> If the test-case starts failing for many targets, not sure if XFAIL
> >> would be the right choice.
> >> Should I just restrict it to x86_64 target for now ?
> >
> > That sounds like a good approach in the interim, until we have
> > a general solution. It will avoid having to maintain a list
> > of targets where it's known to fail.
> Agreed and pre-approved.
Just please test with
RUNTESTFLAGS='--target_board=unix\{-m64,-m32,-m32/-mno-sse\} dg.exp=strlenopt-*.c'
and restrict to { i?86-*-* x86_64-*-* }, e.g. on Solaris it is i?86-*-*
canonical target, even when it supports -m64 multilib.
If you need x86_64 64-bit, that would be { { i?86-*-* x86_64-*-* } && lp64 }
or ! ia32, depending on if -mx32 works or not.
Jakub
next prev parent reply other threads:[~2018-01-12 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 18:46 Prathamesh Kulkarni
2018-01-10 21:40 ` Jeff Law
2018-01-11 9:22 ` Christophe Lyon
2018-01-11 10:58 ` Prathamesh Kulkarni
2018-01-11 12:07 ` Prathamesh Kulkarni
2018-01-11 16:56 ` Martin Sebor
2018-01-11 21:59 ` Rainer Orth
2018-01-12 6:41 ` Martin Sebor
2018-01-12 6:46 ` Prathamesh Kulkarni
2018-01-12 16:28 ` Martin Sebor
2018-01-12 17:46 ` Jeff Law
2018-01-12 17:56 ` Jakub Jelinek [this message]
2018-01-14 9:42 ` Prathamesh Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112175534.GF2063@tucnak \
--to=jakub@redhat.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=msebor@gmail.com \
--cc=prathamesh.kulkarni@linaro.org \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).