From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-472615-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 33258 invoked by alias); 5 Feb 2018 17:16:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 33235 invoked by uid 89); 5 Feb 2018 17:16:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Feb 2018 17:16:24 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 1723C7E42A;	Mon,  5 Feb 2018 17:16:23 +0000 (UTC)
Received: from localhost (unknown [10.33.36.3])	by smtp.corp.redhat.com (Postfix) with ESMTP id BCD146560C;	Mon,  5 Feb 2018 17:16:22 +0000 (UTC)
Date: Mon, 05 Feb 2018 17:16:00 -0000
From: Jonathan Wakely <jwakely@redhat.com>
To: =?iso-8859-1?Q?Fran=E7ois?= Dumont <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Extend aligned_membuf<> usage
Message-ID: <20180205171622.GG13489@redhat.com>
References: <ae3f9581-2d6f-f174-3af6-df067390b08d@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ae3f9581-2d6f-f174-3af6-df067390b08d@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
User-Agent: Mutt/1.9.1 (2017-09-22)
X-SW-Source: 2018-02/txt/msg00183.txt.bz2

On 01/02/18 22:48 +0100, François Dumont wrote:
>Hi
>
>    As we just bump version namespace it might be interesting to do 
>the following change now. What do you think ?

I'd rather not make the code harder to read in all those places just
for an optional mode that nobody uses.

Wouldn't it make more sense to simply make __aligned_buffer identical
to __aligned_membuf for the versioned-namespace? Then at least the
conditional code is only in one place.