From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100184 invoked by alias); 6 Feb 2018 20:11:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100173 invoked by uid 89); 6 Feb 2018 20:11:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 20:11:48 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w16KAOHM042509 for ; Tue, 6 Feb 2018 15:11:46 -0500 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fyhccn00t-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 06 Feb 2018 15:11:46 -0500 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Feb 2018 13:11:45 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Feb 2018 13:11:44 -0700 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w16KBhwM66912370; Tue, 6 Feb 2018 13:11:43 -0700 Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BE2D26A041; Tue, 6 Feb 2018 13:11:43 -0700 (MST) Received: from ibm-tiger.the-meissners.org (unknown [9.32.77.111]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP id A36136A03F; Tue, 6 Feb 2018 13:11:43 -0700 (MST) Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id F15334964B; Tue, 6 Feb 2018 15:11:42 -0500 (EST) Date: Tue, 06 Feb 2018 20:11:00 -0000 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression Mail-Followup-To: Michael Meissner , Segher Boessenkool , GCC Patches , David Edelsohn , Bill Schmidt References: <20180201193116.GA15164@ibm-tiger.the-meissners.org> <20180205115724.GQ21977@gate.crashing.org> <20180205125457.GA20319@ibm-tiger.the-meissners.org> <20180205140131.GT21977@gate.crashing.org> <20180205225751.GA11436@ibm-tiger.the-meissners.org> <20180206171521.GB21977@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180206171521.GB21977@gate.crashing.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 18020620-0004-0000-0000-0000139FF110 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008485; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000248; SDB=6.00985904; UDB=6.00500293; IPR=6.00765271; BA=6.00005813; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019407; XFM=3.00000015; UTC=2018-02-06 20:11:45 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020620-0005-0000-0000-000085FA39FC Message-Id: <20180206201142.GA9763@ibm-tiger.the-meissners.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-06_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802060253 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00270.txt.bz2 On Tue, Feb 06, 2018 at 11:15:21AM -0600, Segher Boessenkool wrote: > Hi! > > On Mon, Feb 05, 2018 at 05:57:51PM -0500, Michael Meissner wrote: > > > We have > > > > > > (define_code_attr su [(sign_extend "s") > > > (zero_extend "u") > > > (fix "s") > > > (unsigned_fix "s") > > > (float "s") > > > (unsigned_float "u")]) > > > > > > and "s" for unsigned_fix seems like it should be "u". Very surprising > > > otherwise (if this is needed in some case, it should just write "s" there > > > instead of ""). > > What about this? You were right. I kept missing this. Sorry. Here is the patch for just this fix. As we've discussed, I'll apply this patch directly as being obvious, while waiting for the other builds. [gcc] 2018-02-06 Michael Meissner PR target/84154 * config/rs6000/rs6000.md (su code attribute): Use "u" for unsigned_fix, not "s". Index: gcc/config/rs6000/rs6000.md =================================================================== --- gcc/config/rs6000/rs6000.md (revision 257269) +++ gcc/config/rs6000/rs6000.md (working copy) @@ -550,7 +550,7 @@ (define_code_attr u [(sign_extend "") (define_code_attr su [(sign_extend "s") (zero_extend "u") (fix "s") - (unsigned_fix "s") + (unsigned_fix "u") (float "s") (unsigned_float "u")]) -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797