From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33698 invoked by alias); 7 Feb 2018 21:02:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33650 invoked by uid 89); 7 Feb 2018 21:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=watch X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Feb 2018 21:01:59 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w17L1vN2003590 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 7 Feb 2018 13:01:57 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w17L1v26003589; Wed, 7 Feb 2018 13:01:57 -0800 (PST) (envelope-from sgk) Date: Wed, 07 Feb 2018 21:02:00 -0000 From: Steve Kargl To: Paul Richard Thomas Cc: "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [PATCH] PR fortran/82049 -- resolve a charlen if possible Message-ID: <20180207210157.GA3555@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180207021706.GA39844@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-02/txt/msg00360.txt.bz2 Thanks. A version of the patch has been commit to 6-branch, 7-branch, and trunk. One regression down, many more to go. -- steve On Wed, Feb 07, 2018 at 08:10:41AM +0000, Paul Richard Thomas wrote: > Hi Steve, > > That's OK for trunk and, if you are possessed of the intestinal > fortitude, 6- and 7-branches. > > Thanks > > Paul > > > On 7 February 2018 at 02:17, Steve Kargl > wrote: > > The attached patch fixes PR fortran/82049. Prior to this > > patch, gfortran was fouling up the resolution of the charlen > > expression in the testcase. The immediately tries to resolve > > the length while parsing the type-spec. > > > > While here, I've introduced an optimization that causes > > gfc_match_type_spec() to return early if the gfortran isn't > > going to be getting a type-spec. This is done be peeking > > at the next character, if it is in [a-z], the we don't have > > a type spec. OK to commit? > > > > > > 2018-02-06 Steven G. Kargl > > > > PR fortran/82049 > > * match.c (gfc_match_type_spec): If the charlen is non-NULL, then > > try to resolve it. While here return early if possible. > > > > 2018-02-06 Steven G. Kargl > > > > PR fortran/82049 > > * gfortran.dg/assumed_charlen_parameter.f90: New test. > > > > > > -- > > Steve > > > > -- > "If you can't explain it simply, you don't understand it well enough" > - Albert Einstein -- Steve 20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4 20161221 https://www.youtube.com/watch?v=IbCHE-hONow