From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 946 invoked by alias); 9 Feb 2018 23:21:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 880 invoked by uid 89); 9 Feb 2018 23:21:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=back! X-Spam-User: qpsmtpd, 3 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 23:21:18 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w19NLGqf041567 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 9 Feb 2018 15:21:16 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w19NLGgJ041566; Fri, 9 Feb 2018 15:21:16 -0800 (PST) (envelope-from sgk) Date: Fri, 09 Feb 2018 23:21:00 -0000 From: Steve Kargl To: Janus Weil Cc: gfortran , gcc-patches Subject: Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90) Message-ID: <20180209232116.GA41530@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-02/txt/msg00559.txt.bz2 On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: > > the attached patch fixes some checking code for PASS arguments in > procedure-pointer components, which does not properly account for the > fact that the PASS argument needs to be polymorphic. > > [The reason for this issue is probably that PPCs were mostly > implemented before polymorphism was available. The corresponding > pass-arg checks for TBPs are ok.] > > The patch also fixes an invalid test case (which was detected thanks > to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for > trunk? Janus, The patch looks ok to me. Trunk is in regression and doc fixes only mode, so you'll probably need to ping Jakub or Richard (ie., release engineer) for an ok. PS: Welcome back! We can definitely use your talent. -- Steve