From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21708 invoked by alias); 9 Feb 2018 23:27:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21380 invoked by uid 89); 9 Feb 2018 23:27:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Following X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 23:27:53 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w19NRqGY041623 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 9 Feb 2018 15:27:52 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w19NRpf1041622; Fri, 9 Feb 2018 15:27:51 -0800 (PST) (envelope-from sgk) Date: Fri, 09 Feb 2018 23:27:00 -0000 From: Steve Kargl To: Janne Blomqvist Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Character length cleanup for Coarray Fortran library Message-ID: <20180209232751.GB41530@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <1518192646-9702-1-git-send-email-blomqvist.janne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518192646-9702-1-git-send-email-blomqvist.janne@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-02/txt/msg00560.txt.bz2 On Fri, Feb 09, 2018 at 06:10:46PM +0200, Janne Blomqvist wrote: > Following the change to use size_t for Fortran character lengths (PR > 78534), this patch modifies the Coarray ABI in a similar way. The > single-image implementation that is included in libgfortran is > updated, but this needs corresponding work in the OpenCoarray library > as well for multi-image support. Damian, can you look into that? > > Regtested on x86_64-pc-linux-gnu, Ok for trunk? > Janne, I've scanned the patch and it appears to a fairly straight foward mechanical s/int/size_t (and similar for nodes). OK to commit (although you may want to wait for a response from Damain or Izaak Beekman). As this breaks an ABI and we've broken it for 8.0, I think this should go into trunk. You may need to ping Jakub or Richard for final approval. -- Steve