Re: Reduce inline limits a bit to compensate changes in inlining metrics

public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed

From: Jan Hubicka <hubicka@ucw.cz>
To: "Martin Liška" <mliska@suse.cz>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: Reduce inline limits a bit to compensate changes in inlining metrics
Date: Tue, 13 Feb 2018 18:09:00 -0000	[thread overview]
Message-ID: <20180213180946.GA8966@kam.mff.cuni.cz> (raw)
In-Reply-To: <97dbd34d-4df4-b652-9684-9e4ba81740f5@suse.cz>

> Hi.
> 
> I see quite SPEC 2006 benchmark changes for -Ofast -march=native:
> (note that size changes are not presented all)

Thanks! It is interesting that I do not see similar observations on Czerny which also
runs spec2006. In partiuclar both AMD machines agrees on soplex milc and bwaves.
They are flat in Czerny graph, so it may be again dependency of AMD machines on code lyaout
we was seeing recently.
https://gcc.opensuse.org/gcc-old/SPEC/CFP/sb-czerny-head-64-2006/410_bwaves_recent_big.png
https://gcc.opensuse.org/gcc-old/SPEC/CFP/sb-czerny-head-64-2006/433_milc_recent_big.png
https://gcc.opensuse.org/gcc-old/SPEC/CFP/sb-czerny-head-64-2006/450_soplex_recent_big.png

We sould take a look at spoplex. Megrez will pick up the patch tonight so we will see if the
regression reproduces on both bulldozer machines.

Honza

> 
> 1) gillan (AMD bulldozer):
> 
> +------------------------------------------+-------+----------+----------+---+-------+-------+
> | Performance Regressions - Execution Time |   Î”   | Previous | Current  | Ïƒ | Î” (B) | Ïƒ (B) |
> +------------------------------------------+-------+----------+----------+---+-------+-------+
> | SPEC/SPEC2006/FP/453.povray              | 6.06% | 180.9933 | 191.9582 | - | 3.48% |     - |
> | SPEC/SPEC2006/FP/410.bwaves              | 5.13% | 307.0029 | 322.7495 | - | 8.11% |     - |
> | SPEC/SPEC2006/FP/433.milc                | 4.80% | 310.4705 | 325.3810 | - | 4.01% |     - |
> | SPEC/SPEC2006/FP/450.soplex              | 3.50% | 449.4463 | 465.1627 | - | 3.09% |     - |
> | SPEC/SPEC2006/INT/471.omnetpp            | 1.41% | 562.2769 | 570.1829 | - | 1.65% |     - |
> | SPEC/SPEC2006/FP/447.dealII              | 1.40% | 359.1753 | 364.1933 | - | 1.66% |     - |
> | SPEC/SPEC2006/INT/483.xalancbmk          | 1.00% | 430.9722 | 435.2821 | - | 7.59% |     - |
> +------------------------------------------+-------+----------+----------+---+-------+-------+
> 
> +-------------------------------------------+--------+----------+----------+---+--------+-------+
> | Performance Improvements - Execution Time |   Î”    | Previous | Current  | Ïƒ | Î” (B)  | Ïƒ (B) |
> +-------------------------------------------+--------+----------+----------+---+--------+-------+
> | SPEC/SPEC2006/INT/429.mcf                 | -7.93% | 606.7478 | 558.6419 | - | -7.42% |     - |
> | SPEC/SPEC2006/INT/473.astar               | -2.07% | 577.5786 | 565.6328 | - | -6.16% |     - |
> | SPEC/SPEC2006/FP/435.gromacs              | -2.01% | 329.9626 | 323.3386 | - | -0.34% |     - |
> | SPEC/SPEC2006/INT/458.sjeng               | -1.71% | 667.0133 | 655.5964 | - | -1.54% |     - |
> | SPEC/SPEC2006/FP/436.cactusADM            | -1.07% | 379.5225 | 375.4560 | - | -4.12% |     - |
> +-------------------------------------------+--------+----------+----------+---+--------+-------+
> 
> +---------------------------------------------------+---------+--------------+--------------+---+---------+-------+
> |          Performance Improvements - size          |    Î”    |   Previous   |   Current    | Ïƒ |  Î” (B)  | Ïƒ (B) |
> +---------------------------------------------------+---------+--------------+--------------+---+---------+-------+
> | SPEC/SPEC2006/FP/482.sphinx3/elf/sections/text    | -15.92% |  244450.0000 |  205522.0000 | - | -9.45%  |     - |
> | SPEC/SPEC2006/FP/482.sphinx3/elf                  | -12.16% |  335640.0000 |  294816.0000 | - | -6.46%  |     - |
> | SPEC/SPEC2006/INT/456.hmmer/elf/sections/text     | -12.14% |  395778.0000 |  347746.0000 | - | -9.75%  |     - |
> | SPEC/SPEC2006/INT/483.xalancbmk/elf/sections/text | -10.43% | 3282082.0000 | 2939698.0000 | - | -11.33% |     - |
> | SPEC/SPEC2006/FP/453.povray/elf/sections/text     | -9.48%  | 1004658.0000 |  909426.0000 | - | -12.68% |     - |
> | SPEC/SPEC2006/INT/400.perlbench/elf/sections/text | -9.42%  | 1141458.0000 | 1033890.0000 | - | -9.75%  |     - |
> | SPEC/SPEC2006/INT/456.hmmer/elf                   | -8.77%  |  508624.0000 |  464024.0000 | - | -7.28%  |     - |
> +---------------------------------------------------+---------+--------------+--------------+---+---------+-------+
> 
> 2) AMD Ryzen 5 machine:
> 
> +------------------------------------------+-------+----------+----------+---+-------+-------+
> | Performance Regressions - Execution Time |   Î”   | Previous | Current  | Ïƒ | Î” (B) | Ïƒ (B) |
> +------------------------------------------+-------+----------+----------+---+-------+-------+
> | SPEC/SPEC2006/FP/450.soplex              | 6.28% | 204.6552 | 217.5132 | - | 8.06% |     - |
> | SPEC/SPEC2006/FP/433.milc                | 6.11% | 200.5912 | 212.8397 | - | 5.81% |     - |
> | SPEC/SPEC2006/FP/410.bwaves              | 3.28% | 145.9785 | 150.7609 | - | 5.37% |     - |
> | SPEC/SPEC2006/INT/462.libquantum         | 1.98% | 306.7858 | 312.8472 | - | 2.14% |     - |
> +------------------------------------------+-------+----------+----------+---+-------+-------+
> 
> +-------------------------------------------+--------+----------+----------+---+--------+-------+
> | Performance Improvements - Execution Time |   Î”    | Previous | Current  | Ïƒ | Î” (B)  | Ïƒ (B) |
> +-------------------------------------------+--------+----------+----------+---+--------+-------+
> | SPEC/SPEC2006/INT/429.mcf                 | -4.71% | 255.8058 | 243.7667 | - | -1.18% |     - |
> | SPEC/SPEC2006/INT/473.astar               | -3.33% | 361.8033 | 349.7520 | - | 0.67%  |     - |
> | SPEC/SPEC2006/FP/482.sphinx3              | -1.28% | 301.7175 | 297.8409 | - | 5.49%  |     - |
> +-------------------------------------------+--------+----------+----------+---+--------+-------+
> 
> +---------------------------------------------------+---------+--------------+--------------+---+---------+-------+
> |          Performance Improvements - size          |    Î”    |   Previous   |   Current    | Ïƒ |  Î” (B)  | Ïƒ (B) |
> +---------------------------------------------------+---------+--------------+--------------+---+---------+-------+
> | SPEC/SPEC2006/FP/482.sphinx3/elf/sections/text    | -17.60% |  202370.0000 |  166754.0000 | - | -9.65%  |     - |
> | SPEC/SPEC2006/FP/482.sphinx3/elf                  | -12.67% |  290680.0000 |  253856.0000 | - | -7.42%  |     - |
> | SPEC/SPEC2006/INT/456.hmmer/elf/sections/text     | -10.58% |  340802.0000 |  304754.0000 | - | -7.92%  |     - |
> | SPEC/SPEC2006/INT/400.perlbench/elf/sections/text | -9.50%  | 1166962.0000 | 1056066.0000 | - | -9.89%  |     - |
> | SPEC/SPEC2006/FP/453.povray/elf/sections/text     | -9.48%  |  993042.0000 |  898882.0000 | - | -13.33% |     - |
> | SPEC/SPEC2006/INT/483.xalancbmk/elf/sections/text | -9.13%  | 3225538.0000 | 2931026.0000 | - | -9.93%  |     - |
> | SPEC/SPEC2006/INT/456.hmmer/elf                   | -8.01%  |  455472.0000 |  418968.0000 | - | -5.44%  |     - |
> | SPEC/SPEC2006/INT/400.perlbench/elf               | -7.45%  | 1538352.0000 | 1423800.0000 | - | -7.69%  |     - |
> +---------------------------------------------------+---------+--------------+--------------+---+---------+-------+
> 
> And I really verified on my Haswell machine that sphinx3 changes:
> 
> bloaty new -- old
>      VM SIZE                     FILE SIZE
>  ++++++++++++++ GROWING       ++++++++++++++
>   +0.1%     +24 .eh_frame         +24  +0.1%
>   [ = ]       0 .symtab           +24  +0.2%
>   [ = ]       0 .strtab           +14  +0.2%
>   +0.3%      +8 .eh_frame_hdr      +8  +0.3%
> 
>  -------------- SHRINKING     --------------
>   [ = ]       0 .debug_loc     -164Ki -37.0%
>   [ = ]       0 .debug_line    -118Ki -23.9%
>  -16.7% -35.4Ki .text         -35.4Ki -16.7%
>   [ = ]       0 .debug_ranges -33.1Ki -74.7%
>   [ = ]       0 .debug_info   -31.0Ki  -9.8%
>  -32.0%     -16 [Unmapped]       -679 -16.8%
>   [ = ]       0 .debug_abbrev    -186  -0.5%
> 
>  -11.8% -35.3Ki TOTAL          -382Ki -23.2%
> 
> Martin
> 
> Martin

     prev parent reply	other threads:[~2018-02-13 18:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 13:34 Jan Hubicka
2018-02-12  9:22 ` Richard Biener
2018-02-13 13:12   ` Martin Liška
2018-02-13 18:09     ` Jan Hubicka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213180946.GA8966@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).