From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] combine: Update links correctly for new I2 (PR84169)
Date: Tue, 13 Feb 2018 22:15:00 -0000 [thread overview]
Message-ID: <20180213221500.GU21977@gate.crashing.org> (raw)
In-Reply-To: <20180212161220.GF5867@tucnak>
On Mon, Feb 12, 2018 at 05:12:20PM +0100, Jakub Jelinek wrote:
> On Mon, Feb 12, 2018 at 03:59:05PM +0000, Segher Boessenkool wrote:
> > If there is a LOG_LINK between two insns, this means those two insns
> > can be combined, as far as dataflow is concerned. There never should
> > be a LOG_LINK between two unrelated insns. If there is one, combine
> > will try to combine the insns without doing all the needed checks if
> > the earlier destination is used before the later insn, etc.
> >
> > Unfortunately we do not update the LOG_LINKs correctly in some cases.
> > This patch fixes at least some of those cases.
> >
> > This fixes the PR's testcase on aarch64. Also tested on 30+ cross
> > compiler, and on powerpc64-linux {-m32,-m64}. Will test on x86_64
> > as well before committing.
>
> Will you check in the testcase too?
>
> My preference would be something like following, so that it can
> be torture-tested on all targets.
Works flawlessly everywhere. I've committed this now, thanks again!
Segher
next prev parent reply other threads:[~2018-02-13 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 15:59 Segher Boessenkool
2018-02-12 17:49 ` Jakub Jelinek
2018-02-12 16:36 ` Segher Boessenkool
2018-02-13 22:15 ` Segher Boessenkool [this message]
2018-02-14 21:49 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213221500.GU21977@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).