From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ian Lance Taylor <iant@golang.org>,
David Edelsohn <dje.gcc@gmail.com>,
Alan Modra <amodra@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Handle PowerPC64 ELFv1 function descriptors in libbacktrace (PR other/82368)
Date: Wed, 14 Feb 2018 12:11:00 -0000 [thread overview]
Message-ID: <20180214121058.GC21977@gate.crashing.org> (raw)
In-Reply-To: <20180214114138.GX5867@tucnak>
Hi Jakub,
On Wed, Feb 14, 2018 at 12:41:38PM +0100, Jakub Jelinek wrote:
> As mentioned in detail in the PR, PowerPC64 ELFv1 function symbols
> point to function descriptors in .opd section rather than actual
> code, and one needs to read the code address from the .opd section
> in order to associate symbols with .text addresses.
>
> Fixed thusly, bootstrapped/regtested on powerpc64-linux (-m32/-m64
> testing) and powerpc64le-linux, ok for trunk?
>
> 2018-02-14 Jakub Jelinek <jakub@redhat.com>
>
> PR other/82368
> * elf.c (EM_PPC64, EF_PPC64_ABI): Undefine and define.
> (struct elf_ppc64_opd_data): New type.
> (elf_initialize_syminfo): Add opd argument, handle symbols
> pointing into the PowerPC64 ELFv1 .opd section.
> (elf_add): Read .opd section on PowerPC64 ELFv1, pass pointer
> to structure with .opd data to elf_initialize_syminfo.
Looks good to me; you may want a libbacktrace maintainer though.
Segher
next prev parent reply other threads:[~2018-02-14 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 11:49 Jakub Jelinek
2018-02-14 12:11 ` Segher Boessenkool [this message]
2018-02-14 13:49 ` Ian Lance Taylor
2018-02-15 11:08 ` Szabolcs Nagy
2018-02-16 8:49 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214121058.GC21977@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).