public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: "james.greenhalgh" <james.greenhalgh@arm.com>,
	       Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
	       "richard.earnshaw" <richard.earnshaw@arm.com>,
	       Christophe Lyon <christophe.lyon@linaro.org>,
	       Richard Sandiford <richard.sandiford@arm.com>
Cc: gcc-patches@gcc.gnu.org, Steve Ellcey <sellcey@cavium.com>
Subject: AArch64 patch ping
Date: Thu, 15 Feb 2018 09:49:00 -0000	[thread overview]
Message-ID: <20180215082632.GF5867@tucnak> (raw)
In-Reply-To: <1515190466.18339.14.camel@cavium.com>

Hi!

I'd like to ping this patch from Steve.

On Fri, Jan 05, 2018 at 02:14:26PM -0800, Steve Ellcey wrote:
> This is a fix for PR target/83335.  We are asserting in
> aarch64_print_address_internal because we have a non Pmode
> address coming from an asm instruction.  My fix is to 
> just allow this by checking this_is_asm_operands.  This is
> what it was doing before the assert was added that caused
> the ICE.
> 
> Verified that it fixed gcc.target/aarch64/asm-2.c in ILP32
> mode and that it caused no regressions.
> 
> Steve Ellcey
> sellcey@cavium.com
> 
> 
> 2018-01-05  Steve Ellcey  <sellcey@cavium.com>
> 
> 	PR target/83335
> 	* config/aarch64/aarch64.c (aarch64_print_address_internal):
> 	Allow non Pmode address in asm statements.
> 
> 
> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
> index a189605..af74212 100644
> --- a/gcc/config/aarch64/aarch64.c
> +++ b/gcc/config/aarch64/aarch64.c
> @@ -5670,8 +5670,9 @@ aarch64_print_address_internal (FILE *f, machine_mode mode, rtx x,
>  {
>    struct aarch64_address_info addr;
>  
> -  /* Check all addresses are Pmode - including ILP32.  */
> -  gcc_assert (GET_MODE (x) == Pmode);
> +  /* Check all addresses are Pmode - including ILP32,
> +     unless this is coming from an asm statement.  */
> +  gcc_assert (GET_MODE (x) == Pmode || this_is_asm_operands);
>  
>    if (aarch64_classify_address (&addr, x, mode, true, type))
>      switch (addr.type)

	Jakub

  reply	other threads:[~2018-02-15  9:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 22:14 [Patch][aarch64][PR target/83335] Fix regression, ICE on gcc.target/aarch64/asm-2.c Steve Ellcey
2018-02-15  9:49 ` Jakub Jelinek [this message]
2018-02-15 14:01 ` Richard Earnshaw (lists)
2018-02-17  0:05   ` Steve Ellcey
2018-02-19 15:32     ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215082632.GF5867@tucnak \
    --to=jakub@redhat.com \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=james.greenhalgh@arm.com \
    --cc=richard.earnshaw@arm.com \
    --cc=richard.sandiford@arm.com \
    --cc=sellcey@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).