From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-473359-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 69705 invoked by alias); 15 Feb 2018 20:16:16 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 69681 invoked by uid 89); 15 Feb 2018 20:16:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=numbered
X-Spam-User: qpsmtpd, 3 recipients
X-HELO: troutmask.apl.washington.edu
Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Feb 2018 20:16:14 +0000
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])	by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w1FKGCA9081464	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);	Thu, 15 Feb 2018 12:16:12 -0800 (PST)	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)	by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w1FKGBLe081463;	Thu, 15 Feb 2018 12:16:11 -0800 (PST)	(envelope-from sgk)
Date: Thu, 15 Feb 2018 20:16:00 -0000
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Janus Weil <janus@gcc.gnu.org>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran, F03] PR 84409: check DTIO arguments for character len
Message-ID: <20180215201611.GA81448@troutmask.apl.washington.edu>
Reply-To: sgk@troutmask.apl.washington.edu
References: <CAKwh3qggU9g0-ATYtq4nWx3ZHg8fuBMxdLj+g4GwMiiuLnRtoA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKwh3qggU9g0-ATYtq4nWx3ZHg8fuBMxdLj+g4GwMiiuLnRtoA@mail.gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-SW-Source: 2018-02/txt/msg00927.txt.bz2

On Thu, Feb 15, 2018 at 09:03:55PM +0100, Janus Weil wrote:
> 
> Regtests cleanly on x86_64-linux-gnu. Ok for trunk?
> 

Looks good to me with a question below.

> Index: gcc/fortran/interface.c
> ===================================================================
> --- gcc/fortran/interface.c	(revision 257672)
> +++ gcc/fortran/interface.c	(working copy)
> @@ -4702,6 +4702,10 @@ check_dtio_arg_TKR_intent (gfc_symbol *fsym, bool
>      gfc_error ("DTIO dummy argument at %L must be an "
>  	       "ASSUMED SHAPE ARRAY", &fsym->declared_at);
>  
> +  if (type == BT_CHARACTER && fsym->ts.u.cl->length != NULL)
> +    gfc_error ("DTIO character argument at %L must have assumed length",
> +               &fsym->declared_at);
> +

If the above is a numbered constraint in the Standard,
can you add a comment of the form /* F03:C1111.  */
above the if-statement.

-- 
Steve