From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31939 invoked by alias); 16 Feb 2018 14:26:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31928 invoked by uid 89); 16 Feb 2018 14:26:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=love X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Feb 2018 14:26:29 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w1GEQOVP007633; Fri, 16 Feb 2018 08:26:25 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w1GEQNgu007632; Fri, 16 Feb 2018 08:26:23 -0600 Date: Fri, 16 Feb 2018 14:26:00 -0000 From: Segher Boessenkool To: Carl Love Cc: gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt Subject: Re: [PATCH, rs6000] Add builtin support for vec_insert4b, vec_extract4b Message-ID: <20180216142622.GJ21977@gate.crashing.org> References: <1517513515.3596.25.camel@us.ibm.com> <20180206154734.GZ21977@gate.crashing.org> <1518638907.7508.30.camel@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518638907.7508.30.camel@us.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00986.txt.bz2 Hi! On Wed, Feb 14, 2018 at 12:08:27PM -0800, Carl Love wrote: > Per Segher's comments on the first version of the patch. I split the > patch into two. Thanks, much easier to read. > 2018-02-13 Carl Love > > * config/rs6000/altivec.h: Add builtin names vec_extract4b > vec_insert4b. * config/rs6000/altivec.h (vec_extract4b, vec_insert4b): New. (Similar for the rest of the changelog). > --- a/gcc/config/rs6000/rs6000-c.c > +++ b/gcc/config/rs6000/rs6000-c.c > @@ -5433,6 +5433,8 @@ const struct altivec_builtin_types altivec_overloaded_builtins[] = { > RS6000_BTI_INTDI, RS6000_BTI_V16QI, RS6000_BTI_UINTSI, 0 }, > { P9V_BUILTIN_VEC_VEXTRACT4B, P9V_BUILTIN_VEXTRACT4B, > RS6000_BTI_INTDI, RS6000_BTI_unsigned_V16QI, RS6000_BTI_UINTSI, 0 }, > + { P9V_BUILTIN_VEC_EXTRACT4B, P9V_BUILTIN_EXTRACT4B, > + RS6000_BTI_unsigned_V2DI, RS6000_BTI_unsigned_V16QI, RS6000_BTI_INTSI, 0 }, The old builtin use unsigned int for the element number (but signed is correct, yes). Looks good. Okay for trunk. Thanks! Segher