From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4801 invoked by alias); 16 Feb 2018 14:48:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4789 invoked by uid 89); 16 Feb 2018 14:48:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=love X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Feb 2018 14:48:47 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w1GEmaRa009036; Fri, 16 Feb 2018 08:48:38 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w1GEmZ6s009035; Fri, 16 Feb 2018 08:48:35 -0600 Date: Fri, 16 Feb 2018 14:48:00 -0000 From: Segher Boessenkool To: Carl Love Cc: gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt Subject: Re: [PATCH, rs6000] Remove non-ABI builtin support for vec_insert4b, vec_extract4b Message-ID: <20180216144834.GK21977@gate.crashing.org> References: <1518638915.7508.31.camel@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518638915.7508.31.camel@us.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00989.txt.bz2 Hi! > This is the second patch that removes the non-ABI vec_insert4b and > vec_extract4b builtin support. It also removes the two existing test > files for the non-ABI builtin instances. A runnable test file for the > ABI specified builtins was added by the first patch. Looks good too; okay for trunk. See changelog comments though. > The patch should also be ported to GCC 7 so we are in compliance with > the ABI. Also okay for 7 (just like the previous patch) after simmering on trunk for a bit. Thanks, Segher > 2018-02-13 Carl Love > > * config/rs6000/altivec.h: Remove vec_vextract4b and vec_vinsert4b. * config/rs6000/altvec.h (vec_vextract4b, vec_vinsert): Delete. > * config/rs6000/rs6000-builtin.def: Remove macro expansion for > VEXTRACT4B, VINSERT4B, VINSERT4B_DI and VEXTRACT4B. > * config/rs6000/rs6000.c: Remove case statements for > P9V_BUILTIN_VEXTRACT4B, P9V_BUILTIN_VEC_VEXTRACT4B, > P9V_BUILTIN_VINSERT4B, P9V_BUILTIN_VINSERT4B_DI, > and P9V_BUILTIN_VEC_VINSERT4B. > * config/rs6000/rs6000-c.c (altivec_expand_builtin): Remove entries for > P9V_BUILTIN_VEC_VEXTRACT4B and P9V_BUILTIN_VEC_VINSERT4B. > * config/rs6000/vsx.md: > * doc/extend.texi: Remove vec_vextract4b, non ABI definitions for > vec_insert4b. > > gcc/testsuite/ChangeLog: > > 2018-02-13 Carl Love > * gcc.target/powerpc/p9-vinsert4b-1.c: Remove test file for non-ABI > tests. > * gcc.target/powerpc/p9-vinsert4b-2.c: Remove test file for non-ABI > tests. [ Whitespace is totally jumbled in the changelog, I guess that is your mail program. ] Segher