From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38489 invoked by alias); 16 Feb 2018 17:56:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38463 invoked by uid 89); 16 Feb 2018 17:56:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=love, HContent-Transfer-Encoding:8bit X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Feb 2018 17:56:56 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w1GHuqaB026293; Fri, 16 Feb 2018 11:56:53 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w1GHuqKM026292; Fri, 16 Feb 2018 11:56:52 -0600 Date: Fri, 16 Feb 2018 17:56:00 -0000 From: Segher Boessenkool To: Carl Love Cc: gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt Subject: Re: [Patch, rs6000] Require Power 8 for vec_float2 builtin Message-ID: <20180216175651.GO21977@gate.crashing.org> References: <1518800329.7508.37.camel@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1518800329.7508.37.camel@us.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg01010.txt.bz2 Hi! On Fri, Feb 16, 2018 at 08:58:49AM -0800, Carl Love wrote: > This patch changes the expansion macros to the equivalent Power 8 > macros. The test now cleanly exits with the message > > error: builtin function ‘__builtin_vsx_float2_v2di’ requires the ‘- > mpower8-vector’ option > > rather then giving an internal compiler error when compiled with the > cpu=power7 option. :-) > The patch was tested by running the full regression suite to ensure no > new regressions were introduced. Additionally, the patch was tested by > hand compiling with the -mcpu=power7 option to verify the issue is > fixed. The testing was don on powerpc64le-unknown-linux-gnu (Power 8 > LE) Do you have a new testcase, too? Or is this all covered by existing tests (which?) Looks great, thanks! Okay for trunk (and for backports after a while, if needed). Segher > * config/rs6000/rs6000-builtin.def: Add BU_P8V_VSX_2 macro definition. > Change FLOAT2 expansions from BU_VSX_2 to BU_P8V_VSX_2 and > from BU_VSX_OVERLOAD_2 to BU_P8V_OVERLOAD_2. > * config/rs6000/rs6000-c.c: Changed macro VSX_BUILTIN_VEC_FLOAT2 > expansion to P8V_BUILTIN_VEC_FLOAT2.