From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Martin Sebor <msebor@gmail.com>
Subject: [committed] Fix overload15.C testcase (PR c++/79064)
Date: Mon, 19 Feb 2018 18:52:00 -0000 [thread overview]
Message-ID: <20180219185224.GM5867@tucnak> (raw)
Hi!
The testcase that has been committed for this PR doesn't work on ilp32
targets, because both 0u - 1 and 0u - 1l are there 0xffffffffu.
The testcase originally filed had proper 0u - 1ll in the second case, which
works on all targets where long long is wider than int (not aware of any
target we support where that wouldn't be true right now).
Tested on x86_64-linux, -m32/-m64, committed to trunk as obvious.
2018-02-19 Jakub Jelinek <jakub@redhat.com>
PR c++/79064
* g++.dg/template/overload15.C (f): Use 0u - 1ll instead of 0u - 1l.
--- gcc/testsuite/g++.dg/template/overload15.C.jj 2018-02-16 23:37:28.682364104 +0100
+++ gcc/testsuite/g++.dg/template/overload15.C 2018-02-19 19:45:48.771094113 +0100
@@ -5,7 +5,7 @@ template <unsigned N>
void f (char (*)[0u - 1 > N ? 1 : 7]);
template <unsigned N>
-void f (char (*)[0u - 1l > N ? 1 : 7]);
+void f (char (*)[0u - 1ll > N ? 1 : 7]);
void f ()
{
Jakub
next reply other threads:[~2018-02-19 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 18:52 Jakub Jelinek [this message]
2018-02-19 20:20 David Edelsohn
2018-02-19 20:49 ` Jakub Jelinek
2018-02-19 20:31 ` David Edelsohn
2018-02-19 22:49 ` Jakub Jelinek
2018-02-19 20:46 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219185224.GM5867@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).