From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19116 invoked by alias); 20 Feb 2018 12:49:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19085 invoked by uid 89); 20 Feb 2018 12:49:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1557 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 12:49:23 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF6F84040858 for ; Tue, 20 Feb 2018 12:49:21 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-85.brq.redhat.com [10.40.204.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF47B2024CA6 for ; Tue, 20 Feb 2018 12:49:20 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id w1KC95a0029590; Tue, 20 Feb 2018 13:09:05 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id w1KC93TN029589; Tue, 20 Feb 2018 13:09:03 +0100 Date: Tue, 20 Feb 2018 12:49:00 -0000 From: Jakub Jelinek To: Martin =?utf-8?B?TGnFoWth?= Cc: gcc-patches@gcc.gnu.org, James Greenhalgh , Richard Earnshaw , Marcus Shawcroft Subject: Re: [PATCH] Fix missing info for -march and -mtune wrong values on aarch64 (PR driver/83193). Message-ID: <20180220120903.GD5867@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg01160.txt.bz2 On Tue, Feb 20, 2018 at 01:05:33PM +0100, Martin Liška wrote: > Hi. > > This is fix for one of multiple issues seen in the PR. Note that I also have some patches > for the others, but it's not stage4 material in my opinion. > This one is quite obvious and should land in GCC 8. > > Output before: > $ ./xgcc -B. -march=sparta /tmp/main.c > cc1: error: unknown value ‘sparta’ for -march > > And after: > $ ./xgcc -B. -march=sparta /tmp/main.c > cc1: error: unknown value ‘sparta’ for -march > cc1: note: valid arguments are: armv8-a armv8.1-a armv8.2-a armv8.3-a armv8.4-a; > > Ready for trunk? > > gcc/ChangeLog: > > 2018-02-20 Martin Liska > > PR driver/83193 > * config/aarch64/aarch64.c (aarch64_print_hint_for_core_or_arch): Print > possible values if we don't have a hint. > --- > gcc/config/aarch64/aarch64.c | 3 +++ > 1 file changed, 3 insertions(+) > > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 228fd1b908d..5fb18c4ca20 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -10633,6 +10633,9 @@ aarch64_print_hint_for_core_or_arch (const char *str, bool arch) > if (hint) > inform (input_location, "valid arguments are: %s;" > " did you mean %qs?", s, hint); > + else > + inform (input_location, "valid arguments are: %s;", s); No trailing ; in this case, that is a separator for did you mean. Otherwise I'd say this is obvious, ok for trunk. Jakub