From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: Thomas Koenig <tkoenig@netcologne.de>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Fix character length in constructors
Date: Tue, 20 Feb 2018 15:29:00 -0000 [thread overview]
Message-ID: <20180220152906.GA30150@troutmask.apl.washington.edu> (raw)
In-Reply-To: <CAO9iq9EdSx-07ni3CbBrUzxnVLme-ynSfTrt-r+D_zx95PgU8Q@mail.gmail.com>
On Tue, Feb 20, 2018 at 09:51:14AM +0200, Janne Blomqvist wrote:
> On Tue, Feb 20, 2018 at 12:41 AM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> > Hello world,
> >
> > when putting in a seemingly innocent simplification for PR 56342,
> > I caused a regression in PR 82823, in PACK. The root cause of
> > this one turned out to be PR 48890, in which structure
> > constructors containing characters were not handled correctly
> > if the lengths did not match.
> >
> > The attached patch fixes that.
> >
> > Regression-tested. OK for trunk?
>
> It's better to use gfc_mpz_get_hwi() instead of mpz_get_si().
> mpz_get_si() returns a long, which is a 32-bit type on win64.
>
> Otherwise Ok with the spelling fix suggested by Steve.
>
Good catch. I don't know how I forgot that you've
spent a lot time fixing int, long, size_t, ssize_t
issues.
--
Steve
next prev parent reply other threads:[~2018-02-20 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 22:41 Thomas Koenig
2018-02-19 22:51 ` Steve Kargl
2018-02-20 7:51 ` Janne Blomqvist
2018-02-20 15:29 ` Steve Kargl [this message]
2018-02-20 18:59 ` Thomas Koenig
2018-02-20 19:10 ` Janne Blomqvist
2018-02-20 19:54 ` Thomas Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220152906.GA30150@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).