From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111473 invoked by alias); 26 Feb 2018 10:49:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110680 invoked by uid 89); 26 Feb 2018 10:49:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 10:49:50 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79BAE8182D17 for ; Mon, 26 Feb 2018 10:49:39 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-85.brq.redhat.com [10.40.204.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9511D111DCF8 for ; Mon, 26 Feb 2018 10:49:30 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id w1QA4REO018795; Mon, 26 Feb 2018 11:04:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id w1QA4On8018794; Mon, 26 Feb 2018 11:04:24 +0100 Date: Mon, 26 Feb 2018 10:49:00 -0000 From: Jakub Jelinek To: Martin =?utf-8?B?TGnFoWth?= Cc: Joseph Myers , Marek Polacek , gcc-patches@gcc.gnu.org, Paolo Bonzini Subject: Re: [PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307) Message-ID: <20180226100424.GO5867@tucnak> Reply-To: Jakub Jelinek References: <1518192504-49084-1-git-send-email-bonzini@gnu.org> <20180213144020.GR5867@tucnak> <20180214205611.GC5866@tucnak> <00c0cd58-1658-5fca-47a7-40c133f9f214@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <00c0cd58-1658-5fca-47a7-40c133f9f214@suse.cz> User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg01401.txt.bz2 On Mon, Feb 26, 2018 at 11:00:48AM +0100, Martin Liška wrote: > On 02/14/2018 11:03 PM, Joseph Myers wrote: > > On Wed, 14 Feb 2018, Jakub Jelinek wrote: > > > >> 2018-02-13 Jakub Jelinek > >> > >> PR sanitizer/84340 > >> * c-decl.c (build_compound_literal): Call pushdecl (decl) even when > >> it is not TREE_STATIC. > >> * c-typeck.c (c_mark_addressable) : Mark > >> not just the COMPOUND_LITERAL_EXPR node itself addressable, but also > >> its COMPOUND_LITERAL_EXPR_DECL. > > > > OK. > > > > Jakub you probably forgot to install the patch. Can you please do it? No, I was asking for ack for stage1, so it is waiting for GCC9. This isn't really a regression and feels risky for GCC8 at this stage, might break invalid programs that try to use compound literals after they go out of scope. Jakub