From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47689 invoked by alias); 26 Feb 2018 17:24:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45617 invoked by uid 89); 26 Feb 2018 17:24:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=10am, love X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 17:24:29 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w1QHOPDe025649; Mon, 26 Feb 2018 11:24:26 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w1QHOPBV025648; Mon, 26 Feb 2018 11:24:25 -0600 Date: Mon, 26 Feb 2018 17:24:00 -0000 From: Segher Boessenkool To: Carl Love Cc: gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt Subject: Re: [PATCH, rs6000] Tests for builtin vec_neg updated Message-ID: <20180226172424.GS21977@gate.crashing.org> References: <1519314070.3293.10.camel@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519314070.3293.10.camel@us.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg01440.txt.bz2 Hi Carl, On Thu, Feb 22, 2018 at 07:41:10AM -0800, Carl Love wrote: > * gcc.target/powerpc/builtins-3.c: Move vec_neg builtin tests to > Power 8 test file. > * gcc.target/powerpc/builtins-3-p8.c: Add vec_neg builtin tests. > * gcc.target/powerpc/fold-vec-neg-char.c(dg-options): Add -mcpu=power8. > * gcc.target/powerpc/fold-vec-neg-floatdouble.c(dg-options): Add > -mcpu=power8. > * gcc.target/powerpc/fold-vec-neg-int.c(dg-options): Remove file. > * gcc.target/powerpc/fold-vec-neg-short.c(dg-options): Add > -mcpu=power8. You should use a space before ( there. > + test_neg_char 1 vspltisw, 1 vsububm > + test_neg_short 1 vspltisw, 1 vsubuhm > + test_neg_int 1 vspltisw, 1 vsubuwm All these are p6 already (so needs just -maltivec). > + test_neg_float 1 xvnegsp > + test_neg_float 1 xvnegdp ... and these are p7 (so needs just -mvsx). I don't understand why you move them to a p8 file? Or ah, this is because the builtin is not defined before p8? Okay for trunk if so :-) Thanks, Segher