public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Will Schmidt <will_schmidt@vnet.ibm.com>
Cc: gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
	       Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, rs6000]  Update altivec-7 testcase(s).
Date: Mon, 26 Feb 2018 17:34:00 -0000	[thread overview]
Message-ID: <20180226173447.GT21977@gate.crashing.org> (raw)
In-Reply-To: <1519403743.31591.3.camel@brimstone.rchland.ibm.com>

On Fri, Feb 23, 2018 at 10:35:43AM -0600, Will Schmidt wrote:
> On Thu, 2018-02-22 at 12:06 -0600, Segher Boessenkool wrote:
> > On Wed, Feb 21, 2018 at 11:33:14AM -0600, Will Schmidt wrote:
> > >   This patch moves the vsx related content from the altivec-7-be test into
> > > a new vsx-7-be test.
> > > This fixes up some test failures as seen on older power systems.
> > 
> > > --- /dev/null
> > > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-7-be.c
> > > @@ -0,0 +1,42 @@
> > > +/* { dg-do compile { target powerpc64-*-* } } */
> > 
> > powerpc*-*-* please, and if you need 64-bit use lp64.
> 
> Thats an existing thing to help indicate 'be' versus 'le'.

But it does not really work.

> altivec-7-be.c:/* { dg-do compile { target powerpc64-*-* } } */
> altivec-7-le.c:/* { dg-do compile { target powerpc64le-*-* } } */
> 
> but yeah, we are potentially missing coverage for -m32. 
> 
> Should I instead try to combine the le,be tests, and set target markers
> on any le/be unique scan-assembler stanzas?

We really want "we're compiling for BE / LE" targets selectors.  I'll
look into it, I guess.


Segher

  reply	other threads:[~2018-02-26 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 17:33 Will Schmidt
2018-02-22 18:06 ` Segher Boessenkool
2018-02-23 16:35   ` Will Schmidt
2018-02-26 17:34     ` Segher Boessenkool [this message]
2018-02-27 15:23       ` [PATCH, rs6000] (v2) " Will Schmidt
2018-02-28 22:12         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226173447.GT21977@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=will_schmidt@vnet.ibm.com \
    --cc=wschmidt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).