From: Jakub Jelinek <jakub@redhat.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fix ICE in generic_overlap (PR 84526)
Date: Mon, 26 Feb 2018 20:49:00 -0000 [thread overview]
Message-ID: <20180226173903.GV5867@tucnak> (raw)
In-Reply-To: <63d4e234-627f-c713-202c-1aac7ba32b2f@gmail.com>
On Mon, Feb 26, 2018 at 10:32:27AM -0700, Martin Sebor wrote:
> That attached revision updates the pass to directly convert
> the poly64_int into offset_int using the API suggested by
> Richard (thanks again). As discussed below, I've made no
> other changes.
>
> Jakub, if you still have concerns that the false positive
> suppression logic isn't sufficiently effective please post
> a test case (or open a new bug). I will look into it when
> I get a chance.
Yes, I still have major concerns, I explained what I'd like to see
(differentiate clearly between what base is, either by adding a flag or
having separate base and base_addr, then in the users you can easily find
out what is what and can decide based on that).
> Until then, I'd like to get the ICE fix committed. Please
> confirm that the attached patch is good to go in.
Due to the above concerns, I don't think the patch is good to go in.
If you find somebody else who thinks the patch is ok, I won't fight against
it though.
Jakub
next prev parent reply other threads:[~2018-02-26 20:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 19:57 Martin Sebor
2018-02-23 20:49 ` Jakub Jelinek
2018-02-23 21:46 ` Martin Sebor
2018-02-24 9:32 ` Richard Sandiford
2018-02-24 14:45 ` Martin Sebor
2018-02-25 10:03 ` Richard Sandiford
2018-02-24 12:49 ` Jakub Jelinek
2018-02-23 23:25 ` Martin Sebor
2018-02-26 17:32 ` Martin Sebor
2018-02-26 20:49 ` Jakub Jelinek [this message]
2018-02-26 18:13 ` Martin Sebor
2018-03-07 15:17 ` Martin Sebor
2018-02-27 12:33 ` Richard Sandiford
2018-03-07 19:37 ` Jeff Law
2018-03-07 22:52 ` Martin Sebor
2018-03-07 23:04 ` Richard Sandiford
2018-03-07 23:59 ` Martin Sebor
2018-03-09 19:07 ` Jeff Law
2018-03-07 19:18 ` Jeff Law
2018-03-07 19:14 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226173903.GV5867@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).