From: Marek Polacek <polacek@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: C++ PATCH to fix ICE with constexpr operator"" (PR c++/84325)
Date: Mon, 26 Feb 2018 17:42:00 -0000 [thread overview]
Message-ID: <20180226174238.GK2995@redhat.com> (raw)
The original testcase was invalid but I added seconds's constructor and made
time_to_wait inline and now the testcase is accepted by clang++.
But we ICE in replace_placeholders_r because we were checking TREE_CONSTANT
on a type. With this patch we accept the code without crashing. (We require
time_to_wait to be inline but clang++ does not.)
Bootstrapped/regtested on x86_64-linux, ok for trunk?
2018-02-26 Marek Polacek <polacek@redhat.com>
PR c++/84325
* tree.c (replace_placeholders_r): Only check TREE_CONSTANT on
non-types.
* g++.dg/cpp1z/pr84325.C: New test.
diff --git gcc/cp/tree.c gcc/cp/tree.c
index 39c1ef28b2d..298517ff83a 100644
--- gcc/cp/tree.c
+++ gcc/cp/tree.c
@@ -3091,7 +3091,7 @@ replace_placeholders_r (tree* t, int* walk_subtrees, void* data_)
replace_placeholders_t *d = static_cast<replace_placeholders_t*>(data_);
tree obj = d->obj;
- if (TREE_CONSTANT (*t))
+ if (!TYPE_P (*t) && TREE_CONSTANT (*t))
{
*walk_subtrees = false;
return NULL_TREE;
diff --git gcc/testsuite/g++.dg/cpp1z/pr84325.C gcc/testsuite/g++.dg/cpp1z/pr84325.C
index e69de29bb2d..dddadc32692 100644
--- gcc/testsuite/g++.dg/cpp1z/pr84325.C
+++ gcc/testsuite/g++.dg/cpp1z/pr84325.C
@@ -0,0 +1,17 @@
+// PR c++/84325
+// { dg-do compile }
+// { dg-options "-std=c++17" }
+
+struct seconds { int i_{0}; constexpr seconds (int) {} };
+template <char... _Digits> constexpr seconds operator""_s() {
+ return seconds(0);
+}
+constexpr seconds operator""_s(long double i) {
+ return seconds(0);
+}
+template<class TYPE>
+struct Param {
+ constexpr static inline seconds time_to_wait{10_s};
+};
+struct Empty {};
+Param<Empty> p;
Marek
next reply other threads:[~2018-02-26 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 17:42 Marek Polacek [this message]
2018-02-26 17:50 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226174238.GK2995@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).