From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36355 invoked by alias); 9 Mar 2018 09:35:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36266 invoked by uid 89); 9 Mar 2018 09:35:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=day X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 09:35:25 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0ABD5402291E for ; Fri, 9 Mar 2018 09:35:21 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.36.118.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE3F3202322A for ; Fri, 9 Mar 2018 09:35:18 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id w2992laQ004152; Fri, 9 Mar 2018 10:02:47 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id w2992jXn004151; Fri, 9 Mar 2018 10:02:45 +0100 Date: Fri, 09 Mar 2018 09:35:00 -0000 From: Jakub Jelinek To: Alexandre Oliva Cc: Jason Merrill , gcc-patches@gcc.gnu.org, mjw@redhat.com Subject: Re: [PR84620] output symbolic entry_view as data2, not addr Message-ID: <20180309090245.GA5867@tucnak> Reply-To: Jakub Jelinek References: <20180306072848.GV5867@tucnak> <20180308093928.GP5867@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00420.txt.bz2 On Fri, Mar 09, 2018 at 05:49:34AM -0300, Alexandre Oliva wrote: > @@ -27699,6 +27780,9 @@ dwarf2out_source_line (unsigned int line, unsigned int column, > { > if (!RESETTING_VIEW_P (table->view)) > { > + table->symviews_since_reset++; > + if (table->symviews_since_reset > symview_upper_bound) > + symview_upper_bound = table->symviews_since_reset; You could have used symview_upper_bound = MAX (symview_upper_bound, table->symviews_since_reset); Also, I'd say there should be symview_upper_bound = 0; in dwarf2out_c_finalize for better behavior of GCC JIT. Otherwise LGTM, but please give Jason a day to comment on. Jakub