From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59547 invoked by alias); 20 Mar 2018 16:42:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59185 invoked by uid 89); 20 Mar 2018 16:42:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=protect X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Mar 2018 16:42:28 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w2KGgI6r001398; Tue, 20 Mar 2018 11:42:24 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w2KGgGWl001394; Tue, 20 Mar 2018 11:42:16 -0500 Date: Tue, 20 Mar 2018 16:42:00 -0000 From: Segher Boessenkool To: Peter Bergner Cc: GCC Patches , Kaushik Phatak , Bill Schmidt , Kelvin Nilsen Subject: Re: [PATCH, rs6000] Fix PR83789: __builtin_altivec_lvx fails for powerpc for altivec-4.c Message-ID: <20180320164216.GK21977@gate.crashing.org> References: <06a0a953-b8ec-f235-01b5-c0de8f4bb9e6@vnet.ibm.com> <20180312185503.GD21977@gate.crashing.org> <469daa3d-584f-62f9-da7d-db1c56638d04@vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <469daa3d-584f-62f9-da7d-db1c56638d04@vnet.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00980.txt.bz2 On Mon, Mar 19, 2018 at 09:12:08PM -0500, Peter Bergner wrote: > On 3/12/18 1:55 PM, Segher Boessenkool wrote: > >> #ifdef HAVE_V8HFmode > >> - else if (mode == V8HFmode) > >> - stvx = TARGET_64BIT > >> - ? gen_altivec_stvx_v8hf_1op (src_exp, memory_address) > >> - : gen_altivec_stvx_v8hf_1op_si (src_exp, memory_address); > >> + else if (mode == V8HFmode) > >> + stvx = gen_altivec_stvx_v8hf (src_exp, dest_exp); > >> #endif > > > > Btw, don't we always have V8HFmode these days? > > I have no idea, I was just working around code that was already there. > Looking at the history, Kelvin seems to have added the tests. > Kelvin, what is the above trying to protect? > > Looking at mu build dirs insn-modes.h, I don't see HAVE_V8HFmode being > defined on either my LE or BE builds. What am I missing? Nothing, I just was confused (we always define the mode in rs6000-modes.def, but that is not the same thing). Sorry. Segher