GCC 8.1 RC1 Bootstrap comparison failure on AIX

GCC 8.1 RC1 Bootstrap comparison failure on AIX

[David Edelsohn]

Jakub and Richi,

GCC 8.1 is experiencing the same bootstrap failure with GCC 8.1 RC1 as
we saw previously.

Bootstrap comparison failure!
gcc/function-tests.o differs

And the same reason: unique, static symbol that includes a random timestamp.

1949c1949

< [1936]        m   0x00000060         1     1    0x02         0x0000
   _GLOBAL__F__nasfarm_edelsohn_src_gcc_8.0.1_RC_20180425_gcc_function_tests.c_DFF67DD7_0x4eda2a0ca57bf446
---
> [1936]        m   0x00000060         1     1    0x02         0x0000     _GLOBAL__F__nasfarm_edelsohn_src_gcc_8.0.1_RC_20180425_gcc_function_tests.c_DFF67DD7_0xbe25963bf76153c

The entire file is protected by CHECKING_P. As DEBUG_FUNCTION
propagates to more and more header files, this triggers when building
without checking.

How do you suggest that we try to fix it this time? I'm not certain
that we can pull out the one function this time.  Should we return to
the -frandom-seed patch for self-test files that you proposed last
time?

Thanks, David

Re: GCC 8.1 RC1 Bootstrap comparison failure on AIX

[Richard Biener]

On Thu, Apr 26, 2018 at 3:40 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> Jakub and Richi,
>
> GCC 8.1 is experiencing the same bootstrap failure with GCC 8.1 RC1 as
> we saw previously.
>
> Bootstrap comparison failure!
> gcc/function-tests.o differs
>
> And the same reason: unique, static symbol that includes a random timestamp.
>
> 1949c1949
>
> < [1936]        m   0x00000060         1     1    0x02         0x0000
>    _GLOBAL__F__nasfarm_edelsohn_src_gcc_8.0.1_RC_20180425_gcc_function_tests.c_DFF67DD7_0x4eda2a0ca57bf446
> ---
>> [1936]        m   0x00000060         1     1    0x02         0x0000     _GLOBAL__F__nasfarm_edelsohn_src_gcc_8.0.1_RC_20180425_gcc_function_tests.c_DFF67DD7_0xbe25963bf76153c
>
> The entire file is protected by CHECKING_P. As DEBUG_FUNCTION
> propagates to more and more header files, this triggers when building
> without checking.
>
> How do you suggest that we try to fix it this time? I'm not certain
> that we can pull out the one function this time.  Should we return to
> the -frandom-seed patch for self-test files that you proposed last
> time?

Does

Index: gcc/cgraph.h
===================================================================
--- gcc/cgraph.h        (revision 259668)
+++ gcc/cgraph.h        (working copy)
@@ -2222,7 +2222,7 @@ public:
   void dump (FILE *f);

   /* Dump symbol table to stderr.  */
-  inline DEBUG_FUNCTION void debug (void)
+  DEBUG_FUNCTION void debug (void)
   {
     dump (stderr);
   }

fix it?

> Thanks, David

Re: GCC 8.1 RC1 Bootstrap comparison failure on AIX

[Jakub Jelinek]

On Thu, Apr 26, 2018 at 09:56:30AM +0200, Richard Biener wrote:
> On Thu, Apr 26, 2018 at 3:40 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> > Jakub and Richi,
> >
> > GCC 8.1 is experiencing the same bootstrap failure with GCC 8.1 RC1 as
> > we saw previously.
> >
> > Bootstrap comparison failure!
> > gcc/function-tests.o differs
> >
> > And the same reason: unique, static symbol that includes a random timestamp.
> >
> > 1949c1949
> >
> > < [1936]        m   0x00000060         1     1    0x02         0x0000
> >    _GLOBAL__F__nasfarm_edelsohn_src_gcc_8.0.1_RC_20180425_gcc_function_tests.c_DFF67DD7_0x4eda2a0ca57bf446
> > ---
> >> [1936]        m   0x00000060         1     1    0x02         0x0000     _GLOBAL__F__nasfarm_edelsohn_src_gcc_8.0.1_RC_20180425_gcc_function_tests.c_DFF67DD7_0xbe25963bf76153c
> >
> > The entire file is protected by CHECKING_P. As DEBUG_FUNCTION
> > propagates to more and more header files, this triggers when building
> > without checking.
> >
> > How do you suggest that we try to fix it this time? I'm not certain
> > that we can pull out the one function this time.  Should we return to
> > the -frandom-seed patch for self-test files that you proposed last
> > time?
> 
> Does

That would be my guess too, but if I try to compile (on x86_64) function-tests.c
with CHECKING_P 0 and put breakpoint on the
*t = ggc_strdup (targetm.strip_name_encoding (IDENTIFIER_POINTER (id)));
line in notice_global_symbol, it is triggered only with _ZNSt9exceptionC2Ev
for weak_global_object_name and nothing else for first_global_object_name.

	Jakub

Re: GCC 8.1 RC1 Bootstrap comparison failure on AIX

[Jakub Jelinek]

On Thu, Apr 26, 2018 at 09:56:30AM +0200, Richard Biener wrote:
> --- gcc/cgraph.h        (revision 259668)
> +++ gcc/cgraph.h        (working copy)
> @@ -2222,7 +2222,7 @@ public:
>    void dump (FILE *f);
> 
>    /* Dump symbol table to stderr.  */
> -  inline DEBUG_FUNCTION void debug (void)
> +  DEBUG_FUNCTION void debug (void)
>    {
>      dump (stderr);
>    }
> 
> fix it?

This is a method defined in the class which is inline even without
inline keyword, we'd need instead:

2018-04-26  Richard Biener  <rguenther@suse.de>
	    Jakub Jelinek  <jakub@redhat.com>

	* cgraph.h (symbol_table): Just declare debug method here.
	* symtab.c (symbol_table::debug): Define.

--- gcc/cgraph.h.jj	2018-02-09 06:44:29.992809176 +0100
+++ gcc/cgraph.h	2018-04-26 10:22:41.176748872 +0200
@@ -2222,10 +2222,7 @@ public:
   void dump (FILE *f);
 
   /* Dump symbol table to stderr.  */
-  inline DEBUG_FUNCTION void debug (void)
-  {
-    dump (stderr);
-  }
+  DEBUG_FUNCTION void debug (void);
 
   /* Return true if assembler names NAME1 and NAME2 leads to the same symbol
      name.  */
--- gcc/symtab.c.jj	2018-02-09 06:44:38.389804442 +0100
+++ gcc/symtab.c	2018-04-26 10:25:28.565831384 +0200
@@ -947,6 +947,12 @@ symbol_table::dump (FILE *f)
     node->dump (f);
 }
 
+DEBUG_FUNCTION void
+symbol_table::debug (void)
+{
+  dump (stderr);
+}
+
 /* Return the cgraph node that has ASMNAME for its DECL_ASSEMBLER_NAME.
    Return NULL if there's no such node.  */
 


	Jakub

Re: GCC 8.1 RC1 Bootstrap comparison failure on AIX

[Jakub Jelinek]

On Thu, Apr 26, 2018 at 10:28:52AM +0200, Jakub Jelinek wrote:
> On Thu, Apr 26, 2018 at 09:56:30AM +0200, Richard Biener wrote:
> > --- gcc/cgraph.h        (revision 259668)
> > +++ gcc/cgraph.h        (working copy)
> > @@ -2222,7 +2222,7 @@ public:
> >    void dump (FILE *f);
> > 
> >    /* Dump symbol table to stderr.  */
> > -  inline DEBUG_FUNCTION void debug (void)
> > +  DEBUG_FUNCTION void debug (void)
> >    {
> >      dump (stderr);
> >    }
> > 
> > fix it?
> 
> This is a method defined in the class which is inline even without
> inline keyword, we'd need instead:

Oops, gengtype can't parse it this way, this should work:

2018-04-26  Richard Biener  <rguenther@suse.de>
	    Jakub Jelinek  <jakub@redhat.com>

	* cgraph.h (symbol_table): Just declare debug method here.
	* symtab.c (symbol_table::debug): Define.

--- gcc/cgraph.h.jj	2018-02-09 06:44:29.992809176 +0100
+++ gcc/cgraph.h	2018-04-26 10:22:41.176748872 +0200
@@ -2222,10 +2222,7 @@ public:
   void dump (FILE *f);
 
   /* Dump symbol table to stderr.  */
-  inline DEBUG_FUNCTION void debug (void)
-  {
-    dump (stderr);
-  }
+  void DEBUG_FUNCTION debug (void);
 
   /* Return true if assembler names NAME1 and NAME2 leads to the same symbol
      name.  */
--- gcc/symtab.c.jj	2018-02-09 06:44:38.389804442 +0100
+++ gcc/symtab.c	2018-04-26 10:25:28.565831384 +0200
@@ -947,6 +947,12 @@ symbol_table::dump (FILE *f)
     node->dump (f);
 }
 
+DEBUG_FUNCTION void
+symbol_table::debug (void)
+{
+  dump (stderr);
+}
+
 /* Return the cgraph node that has ASMNAME for its DECL_ASSEMBLER_NAME.
    Return NULL if there's no such node.  */
 


	Jakub