From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102739 invoked by alias); 30 Apr 2018 12:51:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102712 invoked by uid 89); 30 Apr 2018 12:51:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=decision, articles X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 12:51:42 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1BCB30BEA54 for ; Mon, 30 Apr 2018 12:51:40 +0000 (UTC) Received: from localhost (unknown [10.33.36.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D21510018F9 for ; Mon, 30 Apr 2018 12:51:40 +0000 (UTC) Date: Mon, 30 Apr 2018 13:17:00 -0000 From: Jonathan Wakely To: gcc-patches@gcc.gnu.org Subject: [PATCH] Clarify documentation for -fpie and -fPIE Message-ID: <20180430125139.GA26121@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2018-04/txt/msg01312.txt.bz2 --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 550 I noticed a couple of missing definite articles in the description of -fpie and -fPIE, and found the last sentence unclear. This clarifies that it means you should use these options during compilation if you plan to use -pie during linking (rather than implying you use these during linking as well). I also added a hyphen to "position independent" but maybe that part should wait for a decision on https://gcc.gnu.org/ml/gcc/2018-04/msg00196.html * doc/invoke.texi (-fpie, -fPIE): Fix grammar and clarify interaction with -pie. OK for trunk? --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 1130 commit 169e8c617d502eae8ef37ea60cd199286d318863 Author: Jonathan Wakely Date: Mon Apr 30 13:26:10 2018 +0100 Clarify documentation for -fpie and -fPIE * doc/invoke.texi (-fpie, -fPIE): Fix grammar and clarify interaction with -pie. diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 606e9152cfc..efe66e37901 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -13094,10 +13094,10 @@ are defined to 2. @itemx -fPIE @opindex fpie @opindex fPIE -These options are similar to @option{-fpic} and @option{-fPIC}, but -generated position independent code can be only linked into executables. -Usually these options are used when @option{-pie} GCC option is -used during linking. +These options are similar to @option{-fpic} and @option{-fPIC}, but the +generated position-independent code can be only linked into executables. +Usually these options are used to compile code that will be linked using +the @option{-pie} GCC option. @option{-fpie} and @option{-fPIE} both define the macros @code{__pie__} and @code{__PIE__}. The macros have the value 1 --d6Gm4EdcadzBjdND--