From: Jonathan Wakely <jwakely@redhat.com>
To: Ed Smith-Rowland <3dw4rd@verizon.net>
Cc: Paolo Carlini <paolo.carlini@oracle.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
Vincent Poinot <poinot.v@gmail.com>
Subject: Re: [PATCH] PR libstdc++/80506 fix constant used in condition
Date: Mon, 07 May 2018 12:22:00 -0000 [thread overview]
Message-ID: <20180507122253.GK20930@redhat.com> (raw)
In-Reply-To: <81517154-e7a8-652e-eb65-3221b674a50b@verizon.net>
On 05/05/18 21:19 -0400, Ed Smith-Rowland wrote:
>On 04/26/2017 05:16 AM, Jonathan Wakely wrote:
>>On 26/04/17 11:14 +0200, Paolo Carlini wrote:
>>>.. or maybe using the wrong constant only impacts the performance?!?
>>
>>Yes, I think so. I did some very simple sanity tests and the numbers
>>were identical before and after.
>>
>>
>>
>I was backporting this and saw that __generate_impl does this twice more.
>
>For trunk and branch-8 I have these patches.
>
>OK?
OK, thanks for noticing the additional cases.
prev parent reply other threads:[~2018-05-07 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 14:59 Jonathan Wakely
2017-04-26 9:19 ` Paolo Carlini
2017-04-26 9:27 ` Paolo Carlini
2017-04-26 9:33 ` Jonathan Wakely
2018-05-06 1:19 ` Ed Smith-Rowland
2018-05-07 12:22 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507122253.GK20930@redhat.com \
--to=jwakely@redhat.com \
--cc=3dw4rd@verizon.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
--cc=poinot.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).