From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62607 invoked by alias); 18 May 2018 14:51:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 62587 invoked by uid 89); 18 May 2018 14:51:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1279, slicing, realised, our X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 14:51:16 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5A7EBB40D for ; Fri, 18 May 2018 14:51:14 +0000 (UTC) Received: from localhost (unknown [10.33.36.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A54684428; Fri, 18 May 2018 14:51:14 +0000 (UTC) Date: Fri, 18 May 2018 14:57:00 -0000 From: Jonathan Wakely To: Jason Merrill Cc: gcc-patches List Subject: Re: RFC (libstdc++): C++ PATCH for c++/58407, C++11 deprecation of implicit copy Message-ID: <20180518145113.GQ7974@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-05/txt/msg00928.txt.bz2 On 18/05/18 10:29 -0400, Jason Merrill wrote: >The second patch is some libstdc++ changes to avoid warnings from uses >of the standard library when this warning is on. More are almost >certainly needed. Jonathan, how would you like me to handle this WRT >the library? Check in both patches and let you follow up as needed? Yes, please go ahead and commit the library patch, we'll deal with the rest as needed (I'll give myself a TODO to test with -Wdeprecated-copy and fix what I find). I'm not sure we need the "Avoid implicit deprecation" comments. Adding defaulted definitions is good style anyway, so needs no justification. I'll make sure nobody removes them again in the name of cleaning up unnecessary noise (which they aren't). Did you change your mind about leaving the exception hierarchy without the defautled ops, to get warnings for slicing? I've just realised that our user-declared destructors on the exception classes (which exist so we can control where the key function is emitted) mean they have no implicit move ops. But the standard implies they should have implicitly-declared move ops (because it doesn't declare any special members for those classes). I'll open a bug.