public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir
@ 2018-06-28 23:01 Jakub Jelinek
  2018-06-28 23:48 ` Jeff Law
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jakub Jelinek @ 2018-06-28 23:01 UTC (permalink / raw)
  To: Segher Boessenkool, David Edelsohn, Michael Meissner
  Cc: gcc-patches, David Malcolm

Hi!

The newly added rs6000-modes.h is now included from rs6000.h, so it is
needed when building plugins that include tm.h, but it wasn't listed in the
Makefile fragments and therefore included among PLUGIN_HEADERS.

Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2?

2018-06-28  Jakub Jelinek  <jakub@redhat.com>

	* config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H.

--- gcc/config/rs6000/t-rs6000.jj	2018-05-06 23:13:00.205627800 +0200
+++ gcc/config/rs6000/t-rs6000	2018-06-28 23:31:41.426185017 +0200
@@ -20,6 +20,7 @@
 
 TM_H += $(srcdir)/config/rs6000/rs6000-builtin.def
 TM_H += $(srcdir)/config/rs6000/rs6000-cpus.def
+TM_H += $(srcdir)/config/rs6000/rs6000-modes.h
 PASSES_EXTRA += $(srcdir)/config/rs6000/rs6000-passes.def
 
 rs6000-c.o: $(srcdir)/config/rs6000/rs6000-c.c

	Jakub

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir
  2018-06-28 23:01 [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir Jakub Jelinek
@ 2018-06-28 23:48 ` Jeff Law
  2018-06-29 18:43 ` Michael Meissner
  2018-07-02 16:27 ` Segher Boessenkool
  2 siblings, 0 replies; 4+ messages in thread
From: Jeff Law @ 2018-06-28 23:48 UTC (permalink / raw)
  To: Jakub Jelinek, Segher Boessenkool, David Edelsohn, Michael Meissner
  Cc: gcc-patches, David Malcolm

On 06/28/2018 04:52 PM, Jakub Jelinek wrote:
> Hi!
> 
> The newly added rs6000-modes.h is now included from rs6000.h, so it is
> needed when building plugins that include tm.h, but it wasn't listed in the
> Makefile fragments and therefore included among PLUGIN_HEADERS.
> 
> Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2?
> 
> 2018-06-28  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H.
OK.
jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir
  2018-06-28 23:01 [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir Jakub Jelinek
  2018-06-28 23:48 ` Jeff Law
@ 2018-06-29 18:43 ` Michael Meissner
  2018-07-02 16:27 ` Segher Boessenkool
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Meissner @ 2018-06-29 18:43 UTC (permalink / raw)
  To: Jakub Jelinek
  Cc: Segher Boessenkool, David Edelsohn, Michael Meissner,
	gcc-patches, David Malcolm

On Fri, Jun 29, 2018 at 12:52:59AM +0200, Jakub Jelinek wrote:
> Hi!
> 
> The newly added rs6000-modes.h is now included from rs6000.h, so it is
> needed when building plugins that include tm.h, but it wasn't listed in the
> Makefile fragments and therefore included among PLUGIN_HEADERS.
> 
> Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2?
> 
> 2018-06-28  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H.

Thanks for catching this.

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.ibm.com, phone: +1 (978) 899-4797

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir
  2018-06-28 23:01 [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir Jakub Jelinek
  2018-06-28 23:48 ` Jeff Law
  2018-06-29 18:43 ` Michael Meissner
@ 2018-07-02 16:27 ` Segher Boessenkool
  2 siblings, 0 replies; 4+ messages in thread
From: Segher Boessenkool @ 2018-07-02 16:27 UTC (permalink / raw)
  To: Jakub Jelinek
  Cc: David Edelsohn, Michael Meissner, gcc-patches, David Malcolm

Hi Jakub,

On Fri, Jun 29, 2018 at 12:52:59AM +0200, Jakub Jelinek wrote:
> The newly added rs6000-modes.h is now included from rs6000.h, so it is
> needed when building plugins that include tm.h, but it wasn't listed in the
> Makefile fragments and therefore included among PLUGIN_HEADERS.
> 
> Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2?

Yes please.  Thanks!


Segher


> 2018-06-28  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-02 16:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-28 23:01 [PATCH] Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir Jakub Jelinek
2018-06-28 23:48 ` Jeff Law
2018-06-29 18:43 ` Michael Meissner
2018-07-02 16:27 ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).