From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103304 invoked by alias); 23 Jul 2018 09:14:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103252 invoked by uid 89); 23 Jul 2018 09:14:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=dwarf2out.c, dwarf2outc, UD:dwarf2out.c, H*m:iii X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Jul 2018 09:14:36 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6N9DsS6122056 for ; Mon, 23 Jul 2018 05:14:34 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2kdbctt59r-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Jul 2018 05:14:34 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Jul 2018 10:14:32 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 23 Jul 2018 10:14:29 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6N9ESk543319534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Jul 2018 09:14:28 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA57342045; Mon, 23 Jul 2018 12:14:43 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E0CA42041; Mon, 23 Jul 2018 12:14:43 +0100 (BST) Received: from white.boeblingen.de.ibm.com (unknown [9.152.99.175]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 23 Jul 2018 12:14:43 +0100 (BST) From: Ilya Leoshkevich To: gcc-patches@gcc.gnu.org Cc: krebbel@linux.ibm.com, jasonwucj@gcc.gnu.org, zadeck@gcc.gnu.org, jakub@redhat.com, vmakarov@redhat.com, Ilya Leoshkevich Subject: [PATCH] Fix hard regno checks Date: Mon, 23 Jul 2018 09:14:00 -0000 x-cbid: 18072309-4275-0000-0000-0000029C52D3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18072309-4276-0000-0000-000037A48456 Message-Id: <20180723091424.5040-1-iii@linux.ibm.com> X-SW-Source: 2018-07/txt/msg01240.txt.bz2 FIRST_PSEUDO_REGISTER is not a hard regno, so comparisons should use "<" instead of "<=", and ">=" instread of ">". 2018-07-19 Ilya Leoshkevich * config/nds32/nds32.c (nds32_hard_regno_mode_ok): Replace > with >=. * df-problems.c (df_remove_dead_eq_notes): Replace > with >=. * dwarf2out.c (mem_loc_descriptor): Replace > with >=. * lra-constraints.c (spill_hard_reg_in_range): Replace <= with <. * lra-remat.c (call_used_input_regno_present_p): Replace <= with <. --- gcc/config/nds32/nds32.c | 2 +- gcc/df-problems.c | 2 +- gcc/dwarf2out.c | 2 +- gcc/lra-constraints.c | 2 +- gcc/lra-remat.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/config/nds32/nds32.c b/gcc/config/nds32/nds32.c index 85a29865c7a..721135e6ba1 100644 --- a/gcc/config/nds32/nds32.c +++ b/gcc/config/nds32/nds32.c @@ -4342,7 +4342,7 @@ nds32_hard_regno_nregs (unsigned regno ATTRIBUTE_UNUSED, static bool nds32_hard_regno_mode_ok (unsigned int regno, machine_mode mode) { - if (regno > FIRST_PSEUDO_REGISTER) + if (regno >= FIRST_PSEUDO_REGISTER) return true; if ((TARGET_FPU_SINGLE || TARGET_FPU_DOUBLE) && NDS32_IS_FPR_REGNUM (regno)) diff --git a/gcc/df-problems.c b/gcc/df-problems.c index 3d73bc5df10..7ccb57c287a 100644 --- a/gcc/df-problems.c +++ b/gcc/df-problems.c @@ -3205,7 +3205,7 @@ df_remove_dead_eq_notes (rtx_insn *insn, bitmap live) bool deleted = false; FOR_EACH_INSN_EQ_USE (use, insn) - if (DF_REF_REGNO (use) > FIRST_PSEUDO_REGISTER + if (DF_REF_REGNO (use) >= FIRST_PSEUDO_REGISTER && DF_REF_LOC (use) && (DF_REF_FLAGS (use) & DF_REF_IN_NOTE) && !bitmap_bit_p (live, DF_REF_REGNO (use)) diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index bd45e0b0685..d38aa10ebe6 100644 --- a/gcc/dwarf2out.c +++ b/gcc/dwarf2out.c @@ -15478,7 +15478,7 @@ mem_loc_descriptor (rtx rtl, machine_mode mode, if (dwarf_strict && dwarf_version < 5) break; - if (REGNO (rtl) > FIRST_PSEUDO_REGISTER) + if (REGNO (rtl) >= FIRST_PSEUDO_REGISTER) break; type_die = base_type_for_mode (mode, SCALAR_INT_MODE_P (mode)); if (type_die == NULL) diff --git a/gcc/lra-constraints.c b/gcc/lra-constraints.c index 7eeec767445..f2e4f36ebd0 100644 --- a/gcc/lra-constraints.c +++ b/gcc/lra-constraints.c @@ -5709,7 +5709,7 @@ spill_hard_reg_in_range (int regno, enum reg_class rclass, rtx_insn *from, rtx_i struct lra_insn_reg *reg; for (reg = id->regs; reg != NULL; reg = reg->next) - if (reg->regno <= FIRST_PSEUDO_REGISTER) + if (reg->regno < FIRST_PSEUDO_REGISTER) SET_HARD_REG_BIT (ignore, reg->regno); for (reg = static_id->hard_regs; reg != NULL; reg = reg->next) SET_HARD_REG_BIT (ignore, reg->regno); diff --git a/gcc/lra-remat.c b/gcc/lra-remat.c index 527f2dd2b59..faf74ca8de7 100644 --- a/gcc/lra-remat.c +++ b/gcc/lra-remat.c @@ -708,7 +708,7 @@ call_used_input_regno_present_p (rtx_insn *insn) for (reg = (iter == 0 ? id->regs : static_id->hard_regs); reg != NULL; reg = reg->next) - if (reg->type == OP_IN && reg->regno <= FIRST_PSEUDO_REGISTER + if (reg->type == OP_IN && reg->regno < FIRST_PSEUDO_REGISTER && TEST_HARD_REG_BIT (call_used_reg_set, reg->regno)) return true; return false; -- 2.18.0