From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>,
Richard Biener <rguenther@suse.de>,
Ian Lance Taylor <ian@airs.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Jeff Law <law@redhat.com>, Martin Sebor <msebor@gmail.com>
Subject: Re: [PATCH] Fix the damage done by my other patch from yesterday to strlenopt-49.c
Date: Mon, 30 Jul 2018 15:57:00 -0000 [thread overview]
Message-ID: <20180730155724.GZ17988@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.20.1807301550490.17805@digraph.polyomino.org.uk>
On Mon, Jul 30, 2018 at 03:52:39PM +0000, Joseph Myers wrote:
> On Mon, 30 Jul 2018, Bernd Edlinger wrote:
>
> > In the moment I would already be happy if all STRING_CSTs would
> > be zero terminated.
>
> generic.texi says they need not be. Making the STRING_CST contain only
> the bytes of the initializer and not the trailing NUL in the C case where
> the trailing NUL does not fit in the object initialized would of course
> mean you get non-NUL-terminated STRING_CSTs for valid C code as well.
One thing is whether TREE_STRING_LENGTH includes the trailing NUL byte,
that doesn't need to be the case e.g. for the shortened initializers.
The other thing is whether we as a convenience for the compiler's internals
want to waste some memory for the NUL termination; I think we could avoid
some bugs that way.
Jakub
next prev parent reply other threads:[~2018-07-30 15:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 11:51 Bernd Edlinger
2018-07-30 13:03 ` Richard Biener
2018-07-30 14:41 ` Bernd Edlinger
2018-07-30 15:52 ` Joseph Myers
2018-07-30 15:57 ` Jakub Jelinek [this message]
2018-07-30 16:01 ` Joseph Myers
2018-07-30 16:28 ` Bernd Edlinger
2018-07-30 16:30 ` Jakub Jelinek
2018-07-30 16:08 ` Bernd Edlinger
2018-07-30 17:33 ` Richard Biener
2018-07-31 12:23 ` Bernd Edlinger
2018-07-30 15:22 ` Martin Sebor
2018-07-30 15:49 ` Joseph Myers
2018-08-01 11:20 ` [PATCH] Handle overlength strings in the C FE Bernd Edlinger
2018-08-01 16:04 ` Joseph Myers
2018-08-01 20:06 ` Bernd Edlinger
2018-08-01 20:28 ` Marek Polacek
2018-08-01 20:43 ` Joseph Myers
2018-08-09 14:07 ` Bernd Edlinger
2018-08-09 22:08 ` Joseph Myers
2018-08-24 19:59 ` [PATCHv2] " Bernd Edlinger
2018-09-13 21:44 ` Jeff Law
2018-08-01 17:07 ` [PATCH] " Martin Sebor
2018-08-01 17:37 ` Bernd Edlinger
2018-08-01 21:03 ` Eric Gallager
2018-08-01 22:09 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730155724.GZ17988@tucnak \
--to=jakub@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=msebor@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).