From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79568 invoked by alias); 30 Jul 2018 21:20:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79494 invoked by uid 89); 30 Jul 2018 21:20:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=fwd, kelvin, vec_vaddcuq, 01AM X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jul 2018 21:20:02 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w6ULJx6s004141; Mon, 30 Jul 2018 16:19:59 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w6ULJwU8004140; Mon, 30 Jul 2018 16:19:58 -0500 Date: Mon, 30 Jul 2018 21:20:00 -0000 From: Segher Boessenkool To: Kelvin Nilsen Cc: gcc-patches@gcc.gnu.org Subject: Re: Fwd: [PATCH, rs6000] Replace __uint128_t and __int128_t with __uint128 and __int128 in Power PC built-in documentation Message-ID: <20180730211958.GA16221@gate.crashing.org> References: <84e63e5f-e4fe-b2fe-b944-bbab22bdf295@linux.ibm.com> <6def80ed-43ef-14c0-3482-129f44c1244e@linux.ibm.com> <20180726145420.GW16221@gate.crashing.org> <59f39fa2-64c4-3ce1-a091-6924c8489447@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59f39fa2-64c4-3ce1-a091-6924c8489447@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg01879.txt.bz2 On Fri, Jul 27, 2018 at 10:07:20AM -0500, Kelvin Nilsen wrote: > On 7/26/18 9:54 AM, Segher Boessenkool wrote: > > On Thu, Jul 26, 2018 at 08:40:01AM -0500, Kelvin Nilsen wrote: > >> To improve internal consistency and to improve consistency with published ABI documents, this patch replaces the __uint128_t type with __uint128 and replaces __int128_t with __int128. > > > >> Is this ok for trunk? > > > > Looks good, thanks! Most (all?) of these functions are not documented > > in the ABI, but this is a step forward anyway. Okay for trunk. > > > > What do things like error messages involving these functions look like? > > What types do those say? > > Thanks for review and approval. To respond to your question about error messages: > > > > microdoc3.c:22:3: error: invalid parameter combination for AltiVec intrinsic ‘__builtin_vec_vaddcuq’ > > u1 = vec_vaddcuq (d2, d3); > > ^~ Ah, so no type at all. Well that's good :-) Thanks, Segher