From: James Greenhalgh <james.greenhalgh@arm.com>
To: Sam Tebbs <Sam.Tebbs@arm.com>
Cc: Sudakshina Das <Sudi.Das@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>, nd <nd@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [GCC][PATCH][Aarch64] Stop redundant zero-extension after UMOV when in DI mode
Date: Tue, 31 Jul 2018 22:16:00 -0000 [thread overview]
Message-ID: <20180731221625.GH1826@arm.com> (raw)
In-Reply-To: <9e7ccf5b-55b9-543d-1f9e-f9ab36e93376@arm.com>
On Thu, Jul 26, 2018 at 11:52:15AM -0500, Sam Tebbs wrote:
<snip>
> > Thanks for making the changes and adding more test cases. I do however
> > see that you are only covering 2 out of 4 new
> > *aarch64_get_lane_zero_extenddi<> patterns. The
> > *aarch64_get_lane_zero_extendsi<> were already existing. I don't mind
> > those tests. I would just ask you to add the other two new patterns
> > as well. Also since the different versions of the instruction generate
> > same instructions (like foo_16qi and foo_8qi both give out the same
> > instruction), I would suggest using a -fdump-rtl-final (or any relevant
> > rtl dump) with the dg-options and using a scan-rtl-dump to scan the
> > pattern name. Something like:
> > /* { dg-do compile } */
> > /* { dg-options "-O3 -fdump-rtl-final" } */
> > ...
> > ...
> > /* { dg-final { scan-rtl-dump "aarch64_get_lane_zero_extenddiv16qi"
> > "final" } } */
> >
> > Thanks
> > Sudi
>
> Hi Sudi,
>
> Thanks again. Here's an update that adds 4 more tests, so all 8 patterns
> generated are now tested for!
This is OK for trunk, thanks for the patch (and thanks Sudi for the review!)
Thanks,
James
>
> Below is the updated changelog
>
> gcc/
> 2018-07-26 Sam Tebbs <sam.tebbs@arm.com>
>
> Â Â Â Â Â Â Â * config/aarch64/aarch64-simd.md
> Â Â Â Â Â Â Â (*aarch64_get_lane_zero_extendsi<mode>):
> Â Â Â Â Â Â Â Rename to...
> (*aarch64_get_lane_zero_extend<GPI:mode><VDQQH:mode>): ... This.
> Â Â Â Â Â Â Â Use GPI iterator instead of SI mode.
>
> gcc/testsuite
> 2018-07-26 Sam Tebbs <sam.tebbs@arm.com>
>
> Â Â Â Â Â Â Â * gcc.target/aarch64/extract_zero_extend.c: New file
>
next prev parent reply other threads:[~2018-07-31 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 10:39 Sam Tebbs
2018-07-23 16:01 ` Sudakshina Das
2018-07-25 13:09 ` Sam Tebbs
2018-07-25 18:08 ` Sudakshina Das
2018-07-26 16:52 ` Sam Tebbs
2018-07-31 22:16 ` James Greenhalgh [this message]
2018-08-01 9:13 ` Sam Tebbs
2018-08-01 10:20 ` Sudakshina Das
2018-07-27 12:39 ` Sudakshina Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731221625.GH1826@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Sam.Tebbs@arm.com \
--cc=Sudi.Das@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).