From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22405 invoked by alias); 31 Jul 2018 23:31:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22320 invoked by uid 89); 31 Jul 2018 23:31:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Jul 2018 23:31:01 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w6VNUs9g031498; Tue, 31 Jul 2018 18:30:54 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w6VNUrZq031497; Tue, 31 Jul 2018 18:30:53 -0500 Date: Tue, 31 Jul 2018 23:31:00 -0000 From: Segher Boessenkool To: Bill Schmidt Cc: Richard Earnshaw , gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Subject: Re: [PATCH 11/11] rs6000 - add speculation_barrier pattern Message-ID: <20180731233052.GF16221@gate.crashing.org> References: <1531154299-28349-1-git-send-email-Richard.Earnshaw@arm.com> <1532684275-13041-1-git-send-email-Richard.Earnshaw@arm.com> <1532684275-13041-12-git-send-email-Richard.Earnshaw@arm.com> <319092EF-E719-42D1-B402-DB9AF87B60FD@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <319092EF-E719-42D1-B402-DB9AF87B60FD@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg02023.txt.bz2 On Tue, Jul 31, 2018 at 05:01:02PM -0500, Bill Schmidt wrote: > > On Jul 27, 2018, at 4:37 AM, Richard Earnshaw wrote: > > This patch reworks the existing rs6000_speculation_barrier pattern to > > work with the new __builtin_sepculation_safe_value() intrinsic. The > > change is trivial as it simply requires renaming the existing speculation > > barrier pattern. > > > > So the total patch is to delete 14 characters! > I can't ack the patch, but I am happy with it. Thank you for this work! Looks fine to me, too. I'm sure someone has tested it by now, too ;-) Okay for trunk. Thanks! Segher > > * config/rs6000/rs6000.md (speculation_barrier): Renamed from > > rs6000_speculation_barrier. > > * config/rs6000/rs6000.c (rs6000_expand_builtin): Adjust for > > new barrier pattern name.