From: Jakub Jelinek <jakub@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Cesar Philippidis <cesar@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH,nvptx] Truncate config/nvptx/oacc-parallel.c
Date: Wed, 01 Aug 2018 11:55:00 -0000 [thread overview]
Message-ID: <20180801115503.GN17988@tucnak> (raw)
In-Reply-To: <e267798f-5760-9ac7-956d-71f5206d61dd@suse.de>
On Wed, Aug 01, 2018 at 01:33:09PM +0200, Tom de Vries wrote:
> On 07/31/2018 05:55 PM, Cesar Philippidis wrote:
> > Way back in the GCC 5 days when support for OpenACC was in its infancy,
> > we used to rely on having various GOACC_ thread functions in the runtime
> > to implement the execution model, or there lack of (that version of GCC
> > only supported vector level parallelism). However, beginning with GCC 6,
> > those external functions were replaced with internal functions that get
> > expanded by the nvptx BE directly.
> >
> > This patch removes those stale libgomp functions from the nvptx libgomp
> > target. Is this OK for trunk, or does libgomp still need to maintain
> > backwards compatibility with GCC 5?
> >
> > This patch has been bootstrapped and regtested for x86_64 with nvptx
> > offloading.
>
> AFAIU, if you use a GCC 5 nvptx offloading compiler that generates calls
> to these GOACC_ thread functions, you're also expected to use the GCC 5
> nvptx libgomp.a containing these functions, so I don't see any backwards
> compatibility issues here.
>
> OK for me.
>
> Jakub, do you have an opinion here?
The ABI compatibility is mainly for libgomp.so which hasn't (ever) bumped
the soname and I don't plan to do that any time soon, but even for the
offloaded libgomp.a I guess one might compile with GCC 5 and link with GCC
9 and expect things not to fail miserably. This is a *.a library, can't you
e.g. move those functions to a separate *.c file so that they aren't linked
in unless GCC 5 is really used?
Jakub
next prev parent reply other threads:[~2018-08-01 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 21:58 Remove unused openacc call Nathan Sidwell
2016-04-20 8:47 ` Thomas Schwinge
2016-04-20 10:27 ` Jakub Jelinek
2018-07-31 15:55 ` [PATCH,nvptx] Truncate config/nvptx/oacc-parallel.c Cesar Philippidis
2018-08-01 11:32 ` Tom de Vries
2018-08-01 11:55 ` Jakub Jelinek [this message]
2018-08-01 12:31 ` Tom de Vries
2018-08-01 17:13 ` Nathan Sidwell
2018-08-01 17:34 ` Jakub Jelinek
2019-05-06 8:52 ` [committed] Clean up libgomp GCC 5 legacy support (was: Remove unused openacc call) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801115503.GN17988@tucnak \
--to=jakub@redhat.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).