public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Improve std::rotate usages
Date: Tue, 07 Aug 2018 14:12:00 -0000	[thread overview]
Message-ID: <20180807141204.GN25399@redhat.com> (raw)
In-Reply-To: <09ac2f4a-083c-8345-e6d8-0a13afae0f9e@gmail.com>

On 27/05/18 19:25 +0200, François Dumont wrote:
>Still no chance to review it ?
>
>I'd like this one to go in before submitting other algo related patches.
>
>    * include/bits/stl_algo.h
>    (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))
>    (__rotate(_Ite, _Ite, _Ite, bidirectional_iterator_tag))
>    (__rotate(_Ite, _Ite, _Ite, random_access_iterator_tag)): Move 
>code duplication...
>    (rotate(_Ite, _Ite, _Ite)): ...here.
>    (__stable_partition_adaptive(_FIt, _FIt, _Pred, _Dist, _Pointer, 
>_Dist)):
>    Simplify rotate call.
>    (__rotate_adaptive(_BIt1, _BIt1, _BIt1, _Dist, _Dist, _Bit2, _Dist)):
>    Likewise.
>    (__merge_without_buffer(_BIt, _BIt, _BIt, _Dist, _Dist, _Comp)):
>    Likewise.
>
>François
>
>On 14/05/2018 22:14, François Dumont wrote:
>>Any feedback regarding this patch ?
>>
>>
>>On 02/05/2018 07:26, François Dumont wrote:
>>>Hi
>>>
>>>    std::rotate already returns the expected iterator so there is 
>>>no need for calls to std::advance/std::distance.

Yes, looks like that code predated DR 488 which changed the return
type of std::rotate.

OK for trunk, thanks.


      parent reply	other threads:[~2018-08-07 14:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  5:26 François Dumont
2018-05-14 20:15 ` François Dumont
2018-05-27 22:01   ` François Dumont
2018-06-08  5:55     ` François Dumont
2018-06-12 20:39       ` François Dumont
2018-06-12 23:13         ` Jonathan Wakely
2018-07-24 10:23       ` François Dumont
2018-08-07 14:12     ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180807141204.GN25399@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).