From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3056 invoked by alias); 27 Aug 2018 06:58:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3043 invoked by uid 89); 27 Aug 2018 06:58:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Aug 2018 06:57:58 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4E7B308427D; Mon, 27 Aug 2018 06:57:56 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2670419480; Mon, 27 Aug 2018 06:57:55 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id w7R6vrrY014536; Mon, 27 Aug 2018 08:57:54 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id w7R6vpem014535; Mon, 27 Aug 2018 08:57:51 +0200 Date: Mon, 27 Aug 2018 06:58:00 -0000 From: Jakub Jelinek To: David Malcolm Cc: Joseph Myers , Richard Biener , GCC Patches Subject: Re: [PATCH] v2: Formatted printing for dump_* in the middle-end Message-ID: <20180827065751.GB2218@tucnak> Reply-To: Jakub Jelinek References: <1533232447-54802-1-git-send-email-dmalcolm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533232447-54802-1-git-send-email-dmalcolm@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01642.txt.bz2 On Thu, Aug 02, 2018 at 01:54:07PM -0400, David Malcolm wrote: > +/* An attribute for annotating formatting printing functions that use > + the dumpfile/optinfo formatting codes. These are the pretty_printer > + format codes (see pretty-print.c), with additional codes for middle-end > + specific entities (see dumpfile.c). */ > + > +#if GCC_VERSION >= 3005 > +#define ATTRIBUTE_GCC_DUMP_PRINTF(m, n) \ > + __attribute__ ((__format__ (__gcc_dump_printf__, m ,n))) \ > + ATTRIBUTE_NONNULL(m) > +#else > +#define ATTRIBUTE_GCC_DUMP_PRINTF(m, n) ATTRIBUTE_NONNULL(m) > +#endif Why >= 3005 rather than >= 9000 ? GCC 8 and earlier will not handle that format attribute anyway and will just loudly complain. Jakub