From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127444 invoked by alias); 28 Aug 2018 12:26:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127435 invoked by uid 89); 28 Aug 2018 12:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:738 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 12:26:32 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A19B73082DD2; Tue, 28 Aug 2018 12:26:31 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FCD360A9F; Tue, 28 Aug 2018 12:26:30 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id w7SCQSpF022437; Tue, 28 Aug 2018 14:26:28 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id w7SCQQGj022436; Tue, 28 Aug 2018 14:26:26 +0200 Date: Tue, 28 Aug 2018 12:26:00 -0000 From: Jakub Jelinek To: David Malcolm Cc: Joseph Myers , Richard Biener , GCC Patches Subject: Re: [PATCH] Fix version check for ATTRIBUTE_GCC_DUMP_PRINTF Message-ID: <20180828122626.GO2218@tucnak> Reply-To: Jakub Jelinek References: <20180827065751.GB2218@tucnak> <1535416331-352-1-git-send-email-dmalcolm@redhat.com> <20180828064359.GM2218@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180828064359.GM2218@tucnak> User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01761.txt.bz2 On Tue, Aug 28, 2018 at 08:43:59AM +0200, Jakub Jelinek wrote: > On Mon, Aug 27, 2018 at 08:32:11PM -0400, David Malcolm wrote: > > gcc/ChangeLog: > > * dumpfile.h (ATTRIBUTE_GCC_DUMP_PRINTF): Change version check on > > GCC_VERSION for usage of "__gcc_dump_printf__" format from > > >= 3005 to >= 9000. > > Ok, thanks. Another option would be to use __gcc_tdiag__ for GCC_VERSION >= 3005 and < 9000, that differs from __gcc_dump_printf__ only in %E (tree vs. gimple *) and %D/%F/%V/%K added to __gcc_tdiag__, so worst case one would get a couple of rare warnings when %E is used somewhere; certainly better than having a warning on every TU that includes dumpfile.h. Jakub