From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75578 invoked by alias); 28 Aug 2018 22:00:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75229 invoked by uid 89); 28 Aug 2018 22:00:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=impact, localized, 1.54, H*f:sk:1532542 X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 22:00:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D409518A; Tue, 28 Aug 2018 15:00:16 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4EA23F5BD; Tue, 28 Aug 2018 15:00:15 -0700 (PDT) Date: Tue, 28 Aug 2018 22:00:00 -0000 From: James Greenhalgh To: Luis Machado Cc: Siddhesh Poyarekar , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , nd Subject: Re: [PATCH] [AArch64, Falkor] Switch to using Falkor-specific vector costs Message-ID: <20180828220012.GB22590@arm.com> References: <1532542234-24351-1-git-send-email-luis.machado@linaro.org> <20180731225330.GJ1826@arm.com> <1f4f1c5f-5e99-1537-10c0-fad44ed3f89c@gotplt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01804.txt.bz2 On Mon, Aug 27, 2018 at 10:05:17AM -0500, Luis Machado wrote: > Hi, > > On 08/08/2018 04:54 AM, Siddhesh Poyarekar wrote: > > On 08/01/2018 04:23 AM, James Greenhalgh wrote: > >> On Wed, Jul 25, 2018 at 01:10:34PM -0500, Luis Machado wrote: > >>> The adjusted vector costs give Falkor a reasonable boost in > >>> performance for FP > >>> benchmarks (both CPU2017 and CPU2006) and doesn't change INT > >>> benchmarks that > >>> much. About 0.7% for CPU2017 FP and 1.54% for CPU2006 FP. > >>> > >>> OK for trunk? > >> > >> OK if this is what works best for your subtarget. > >> > > > > I have pushed this for Luis since he is on holiday. > > > > Thanks, > > Siddhesh > > Given this has a significant performance impact on Falkor and the > changes are very localized and specific to Falkor, it would be great to > have them on GCC 8. Would it be ok to push it? I've not got a problem with this if your opinion is that the risk is worthwhile for Falkor. Thanks, James