From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-486048-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 29252 invoked by alias); 20 Sep 2018 14:22:28 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 29223 invoked by uid 89); 20 Sep 2018 14:22:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Sep 2018 14:22:26 +0000
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id DB43E2BEEE;	Thu, 20 Sep 2018 14:22:24 +0000 (UTC)
Received: from localhost (unknown [10.33.36.94])	by smtp.corp.redhat.com (Postfix) with ESMTP id 795EF84EE;	Thu, 20 Sep 2018 14:22:24 +0000 (UTC)
Date: Thu, 20 Sep 2018 14:22:00 -0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>, libstdc++@gcc.gnu.org,	gcc Patches <gcc-patches@gcc.gnu.org>, danglin@gcc.gnu.org,	sandra@gcc.gnu.org
Subject: Re: [PATCH] PR libstdc++/78179 run long double tests separately
Message-ID: <20180920142223.GF23172@redhat.com>
References: <20180903145430.GA11187@redhat.com> <CAKdteOYBchV9Wc7=PfeGAYHqro9LWu5SisFmuW2XepGqRes9Jg@mail.gmail.com> <yddbm8tgphh.fsf@CeBiTec.Uni-Bielefeld.DE> <CAKdteObW79vYS=8spz0KgQA_Hk+LiMY+AusgadaCNU49qnGy6Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAKdteObW79vYS=8spz0KgQA_Hk+LiMY+AusgadaCNU49qnGy6Q@mail.gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
User-Agent: Mutt/1.9.2 (2017-12-15)
X-SW-Source: 2018-09/txt/msg01151.txt.bz2

On 20/09/18 15:36 +0200, Christophe Lyon wrote:
>On Wed, 19 Sep 2018 at 23:13, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>
>> Hi Christophe,
>>
>> > I have noticed failures on hypot-long-double.cc on arm, so I suggest we add:
>> >
>> > diff --git
>> > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
>> > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
>> > index 8a05473..4c2e33b 100644
>> > --- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
>> > +++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
>> > @@ -17,7 +17,7 @@
>> >
>> >  // { dg-options "-std=gnu++17" }
>> >  // { dg-do run { target c++17 } }
>> > -// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux* nios2-*-* } }
>> > +// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux*
>> > nios2-*-* arm*-*-* } }
>> >
>> >  // Run the long double tests from hypot.cc separately, because they fail on a
>> >  // number of targets. See PR libstdc++/78179 for details.
>> >
>> > OK?
>>
>> just a nit (and not a review): I'd prefer the target list to be sorted
>> alphabetically, not completely random.
>>
>
>Sure, I can sort the whole list, if OK on principle.

Yes, please go ahead and commit it with the sorted list.