From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: jwakely@redhat.com
Cc: christophe.lyon@linaro.org, ro@cebitec.uni-bielefeld.de,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
danglin@gcc.gnu.org, sandra@gcc.gnu.org
Subject: Re: [PATCH] PR libstdc++/78179 run long double tests separately
Date: Fri, 21 Sep 2018 01:14:00 -0000 [thread overview]
Message-ID: <201809210052.w8L0qngp025707@ignucius.se.axis.com> (raw)
In-Reply-To: <20180920142223.GF23172@redhat.com> (message from Jonathan Wakely on Thu, 20 Sep 2018 15:22:23 +0100)
> Date: Thu, 20 Sep 2018 15:22:23 +0100
> From: Jonathan Wakely <jwakely@redhat.com>
> On 20/09/18 15:36 +0200, Christophe Lyon wrote:
> >On Wed, 19 Sep 2018 at 23:13, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> >>
> >> Hi Christophe,
> >>
> >> > I have noticed failures on hypot-long-double.cc on arm, so I suggest we add:
> >> >
> >> > diff --git
> >> > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > index 8a05473..4c2e33b 100644
> >> > --- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > +++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > @@ -17,7 +17,7 @@
> >> >
> >> > // { dg-options "-std=gnu++17" }
> >> > // { dg-do run { target c++17 } }
> >> > -// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux* nios2-*-* } }
> >> > +// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux*
> >> > nios2-*-* arm*-*-* } }
> >> >
> >> > // Run the long double tests from hypot.cc separately, because they fail on a
> >> > // number of targets. See PR libstdc++/78179 for details.
> >> >
> >> > OK?
> >>
> >> just a nit (and not a review): I'd prefer the target list to be sorted
> >> alphabetically, not completely random.
> >>
> >
> >Sure, I can sort the whole list, if OK on principle.
>
> Yes, please go ahead and commit it with the sorted list.
"Me too". Can I please, rather than piling on to a target list,
replace the whole xfail-list with the equivalent of "target { !
large_long_double }" (an already-existing "effective target")?
I'll leave the thought of running the test only for
large_long_double targets (qualifying the dg-do run) instead of
an xfail-clause for maintainers.
brgds, H-P
next prev parent reply other threads:[~2018-09-21 0:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:54 Jonathan Wakely
2018-09-19 21:13 ` Christophe Lyon
2018-09-19 21:18 ` Rainer Orth
2018-09-20 13:40 ` Christophe Lyon
2018-09-20 14:22 ` Jonathan Wakely
2018-09-20 17:14 ` Christophe Lyon
2018-09-21 1:14 ` Hans-Peter Nilsson [this message]
2018-09-21 10:25 ` Richard Earnshaw (lists)
2018-09-21 10:39 ` Jonathan Wakely
2018-09-21 10:50 ` Richard Earnshaw (lists)
2018-09-21 11:36 ` Jonathan Wakely
2018-09-21 14:01 ` Hans-Peter Nilsson
2018-09-21 16:10 ` Jonathan Wakely
2018-09-21 10:34 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809210052.w8L0qngp025707@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=christophe.lyon@linaro.org \
--cc=danglin@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ro@cebitec.uni-bielefeld.de \
--cc=sandra@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).