From: Segher Boessenkool <segher@kernel.crashing.org>
To: Will Schmidt <will_schmidt@vnet.ibm.com>
Cc: David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, rs6000] Update vec_splat references in testcases for validity.
Date: Fri, 21 Sep 2018 14:36:00 -0000 [thread overview]
Message-ID: <20180921143354.GF23155@gate.crashing.org> (raw)
In-Reply-To: <1537469575.19375.24.camel@brimstone.rchland.ibm.com>
Hi Will,
On Thu, Sep 20, 2018 at 01:52:55PM -0500, Will Schmidt wrote:
> This updates those powerpc testsuite tests that are using the
> vec_splat() builtin with an invalid arg1. Per discussions during the
> review of gimple-folding for vec_splat(), it was clarified
> that arg1 for vec_splat() should be a valid index into the
> referenced vector (no modulo).
> 2018-11-20 Will Schmidt <will_schmidt@vnet.ibm.com>
>
> * gcc.target/powerpc/fold-vec-splat-char.c: Remove invalid
> vec_splat calls from recently added tests. Update instruction counts.
(Two spaces after dot.)
> * gcc.target/powerpc/fold-vec-splat-floatdouble.c: Same.
> * gcc.target/powerpc/fold-vec-splat-int.c: Same.
> * gcc.target/powerpc/fold-vec-splat-pixel.c: Same.
> * gcc.target/powerpc/fold-vec-splat-short.c: Same.
> * g++.dg/ext/altivec-6.C: Updated vec_splat() calls.
"Update".
Other than those trivialities this looks fine to me. Okay for trunk.
Thank you!
Segher
next prev parent reply other threads:[~2018-09-21 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 18:57 Will Schmidt
2018-09-21 14:36 ` Segher Boessenkool [this message]
2018-09-25 15:47 ` [PATCH, rs6000] Update vec_splat references in testcases for validity. (pass2) Will Schmidt
2018-09-25 17:58 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921143354.GF23155@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).