From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR libstdc++/87135 Rehash only when necessary (LWG2156)
Date: Fri, 21 Sep 2018 17:13:00 -0000 [thread overview]
Message-ID: <20180921164950.GO23172@redhat.com> (raw)
In-Reply-To: <a263be37-f36b-b616-3c38-c885586d1e2f@gmail.com>
On 21/09/18 18:10 +0200, François Dumont wrote:
>Here is the patch complement.
>
>load_factor.cc failure revealed a bug in load factor management. Now
>computation of _M_next_resize is consistent throughout the different
>places where it is set.
>
>The 2 other tests only have to be adapted.
>
>Â Â Â PR libstdc++/87135
>Â Â Â * src/c++11/hashtable_c++0x.cc (_Prime_rehash_policy::_M_next_bkt):
>Â Â Â Use __builtin_floor to compute _M_next_resize.
>Â Â Â * testsuite/23_containers/unordered_set/hash_policy/71181.cc: Adapt.
>Â Â Â * testsuite/23_containers/unordered_set/hash_policy/prime_rehash.cc:
>Â Â Â Adapt.
>
>Now fully tested under x86_64.
>
>Ok to commit ?
OK, thanks.
prev parent reply other threads:[~2018-09-21 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 6:43 François Dumont
2018-09-18 8:46 ` Jonathan Wakely
2018-09-18 21:24 ` François Dumont
2018-09-19 9:16 ` Jonathan Wakely
2018-09-19 11:21 ` Jonathan Wakely
2018-09-19 16:24 ` François Dumont
2018-09-21 16:17 ` François Dumont
2018-09-21 17:13 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921164950.GO23172@redhat.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).